test: add semver assertions for numeric context values#365
Merged
toddbaert merged 2 commits intoopen-feature:mainfrom Apr 13, 2026
Merged
test: add semver assertions for numeric context values#365toddbaert merged 2 commits intoopen-feature:mainfrom
toddbaert merged 2 commits intoopen-feature:mainfrom
Conversation
Add Float and Integer context type coverage to the semver test suite: - Add Float rows (1 and 1.2) to the partial version handling scenario - Add semver-numeric-context-flag targeting rule using '>' operator - Add new 'numeric context value handling' scenario asserting Float and Integer context values compare correctly against string semver targets Closes open-feature#237 Signed-off-by: buildingisfun23 <buildingisfun23@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new flag semver-numeric-context-flag to the testkit flags and adds corresponding Gherkin test scenarios to verify semantic version comparison with numeric (Float and Integer) and string context values. I have no feedback to provide as there were no review comments.
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Member
|
Thanks @buildingisfun23 I made some basic tweaks on the naming and added a missing tag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #237
Floatrows (1and1.2) to the existing partial version handling scenario to assert that float context values are handled correctly bysem_versemver-numeric-context-flagflag definition (using the>operator against"1.1") toevaluator/flags/testkit-flags.json@semver-numeric-context) that assertsFloatandIntegercontext values compare correctly against string semver targets (e.g.1.2 (Float) > "1.1"→ match)Test coverage added