fix: various custom operator conformance fixes#1950
fix: various custom operator conformance fixes#1950leakonvalinka wants to merge 4 commits intoopen-feature:mainfrom
Conversation
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
There was a problem hiding this comment.
Code Review
This pull request fixes an indentation issue in fractional.go and updates the semantic version parsing logic in semver.go to normalize uppercase 'V' prefixes. Additionally, a test case was added to semver_test.go to verify this normalization. I have no feedback to provide.
224b4d5 to
4d2eb3b
Compare
There was a problem hiding this comment.
@leakonvalinka Thanks!
Looks great. I made some small tweaks for consistency with other implementations with this commit:
- used a JSON "round trip" to make the $ref replace much easier (because whitespace will be predictable)
- renamed a func (
parseSemanticVersiontonormalizeVersion)
I also updated the go-flagd-provider in use, which means we could update some of the excludes here (for instance, we were still using fractional-v1). I also added a comment here explaining why a lot of the exclusions are permanent and justified.
Signed-off-by: Lea Konvalinka <lea.konvalinka@dynatrace.com>
Signed-off-by: Lea Konvalinka <lea.konvalinka@dynatrace.com>
Signed-off-by: Lea Konvalinka <lea.konvalinka@dynatrace.com>
…impler, method rename, tweak excludes Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
cc4f80e to
39c4820
Compare
|



Fixes: #1942
Related: