Skip to content

chore: improve eventing #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2024
Merged

chore: improve eventing #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e07700e
expose provider name
Kavindu-Dodan Jan 30, 2024
b1d3aad
add buffer to event channel
Kavindu-Dodan Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions openfeature/event_executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ func newEventExecutor(logger logr.Logger) *eventExecutor {
apiRegistry: map[EventType][]EventCallback{},
scopedRegistry: map[string]scopedCallback{},
logger: logger,
eventChan: make(chan eventPayload, 1),
eventChan: make(chan eventPayload, 5),
}

executor.startEventListener()
Expand Down Expand Up @@ -189,7 +189,7 @@ func (e *eventExecutor) emitOnRegistration(

if message != "" {
(*callback)(EventDetails{
providerName: providerReference.featureProvider.Metadata().Name,
ProviderName: providerReference.featureProvider.Metadata().Name,
ProviderEventDetails: ProviderEventDetails{
Message: message,
},
Expand Down Expand Up @@ -355,7 +355,7 @@ func (e *eventExecutor) executeHandler(f func(details EventDetails), event Event
}()

f(EventDetails{
providerName: event.ProviderName,
ProviderName: event.ProviderName,
ProviderEventDetails: ProviderEventDetails{
Message: event.Message,
FlagChanges: event.FlagChanges,
Expand Down
18 changes: 9 additions & 9 deletions openfeature/event_executor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,8 @@ func TestEventHandler_Eventing(t *testing.T) {
t.Fatalf("timeout - event did not trigger")
}

if result.providerName != eventingProvider.Metadata().Name {
t.Errorf("expected %s, but got %s", eventingProvider.Metadata().Name, result.providerName)
if result.ProviderName != eventingProvider.Metadata().Name {
t.Errorf("expected %s, but got %s", eventingProvider.Metadata().Name, result.ProviderName)
}

if result.Message != "ReadyMessage" {
Expand Down Expand Up @@ -1120,29 +1120,29 @@ func TestEventHandler_multiSubs(t *testing.T) {
globalEvents := make(chan string, 10)
go func() {
for rsp := range rspGlobal {
globalEvents <- rsp.providerName
globalEvents <- rsp.ProviderName
}
}()

clientAEvents := make(chan string, 10)
go func() {
for rsp := range rspClientA {
if rsp.providerName != "providerOther" {
t.Errorf("incorrect event provider association, expected %s, got %s", "providerOther", rsp.providerName)
if rsp.ProviderName != "providerOther" {
t.Errorf("incorrect event provider association, expected %s, got %s", "providerOther", rsp.ProviderName)
}

clientAEvents <- rsp.providerName
clientAEvents <- rsp.ProviderName
}
}()

clientBEvents := make(chan string, 10)
go func() {
for rsp := range rspClientB {
if rsp.providerName != "providerOther" {
t.Errorf("incorrect event provider association, expected %s, got %s", "providerOther", rsp.providerName)
if rsp.ProviderName != "providerOther" {
t.Errorf("incorrect event provider association, expected %s, got %s", "providerOther", rsp.ProviderName)
}

clientBEvents <- rsp.providerName
clientBEvents <- rsp.ProviderName
}
}()

Expand Down
2 changes: 1 addition & 1 deletion openfeature/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ type Event struct {
}

type EventDetails struct {
providerName string
ProviderName string
ProviderEventDetails
}

Expand Down