fix: make flagsmith classes public #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <toddbaert@gmail.com>
Member
Author
|
Closes: #211 |
Signed-off-by: Todd Baert <toddbaert@gmail.com>
Member
Author
|
@dabeeeenster @ajhelsby I also noticed that the FlagsmithClient was a a static member. That seems like it could be a potential problem to me if users instantiate multiple flagsmith providers (probably an edge case). Our bug check pointed it out when I made the class public. I've made the internal flagsmith member and instance member now. Is that OK? |
beeme1mr
approved these changes
Feb 6, 2023
matthewelwell
approved these changes
Feb 6, 2023
Merged
DBlanchard88
pushed a commit
to DBlanchard88/java-sdk-contrib
that referenced
this pull request
Apr 29, 2024
…e#213) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making access modifiers for supposedly public classes public.