-
Notifications
You must be signed in to change notification settings - Fork 58
feat: A new inline evaluating provider based on jsonlogic.com #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @justinabrahms, thanks for putting this together. It's great to see new providers like this added to the contribs repo. I'll let @toddbaert and/or @Kavindu-Dodan handle the full review (I'm not a Java person) but the basics look good. By the way, flagd extends JSON logic to support deterministic splits. If that's ever a requirement here, please consider using the same flag configuration and hash algorithm. https://github.com/open-feature/flagd/blob/main/docs/configuration/fractional_evaluation.md |
...-evaluating-provider/main/java/dev/openfeature/contrib/providers/inlineeval/RuleFetcher.java
Show resolved
Hide resolved
...aluating-provider/test/java/dev/openfeature/contrib/providers/inlineeval/ExampleFetcher.java
Outdated
Show resolved
Hide resolved
|
Could you add a EDIT: Actually, after testing a bit I don't think your tests are running in the CI for this reason, and the package will probably contain no bytecode. I added a test that should have failed and it did not. |
toddbaert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in theory, but I think you'll need to resolve this or no actual java bytecode will be published.
|
You may want to add an entry here, or this will default to 1.0 on release (up to you though). |
08ee315 to
8d9fb3d
Compare
...ng-provider/src/main/java/dev/openfeature/contrib/providers/inlineeval/FileBasedFetcher.java
Outdated
Show resolved
Hide resolved
...der/src/main/java/dev/openfeature/contrib/providers/inlineeval/InlineEvaluatingProvider.java
Outdated
Show resolved
Hide resolved
...src/test/java/dev/openfeature/contrib/providers/inlineeval/InlineEvaluatingProviderTest.java
Outdated
Show resolved
Hide resolved
...der/src/main/java/dev/openfeature/contrib/providers/inlineeval/InlineEvaluatingProvider.java
Outdated
Show resolved
Hide resolved
8d9fb3d to
585f010
Compare
c6d8ab9 to
81f70d3
Compare
Signed-off-by: Justin Abrahms <justin@abrah.ms>
Signed-off-by: Justin Abrahms <justin@abrah.ms>
Signed-off-by: Justin Abrahms <justin@abrah.ms>
…ance. Signed-off-by: Justin Abrahms <justin@abrah.ms>
Signed-off-by: Justin Abrahms <justin@abrah.ms>
Signed-off-by: Justin Abrahms <justin@abrah.ms>
Signed-off-by: Justin Abrahms <justin@abrah.ms>
Signed-off-by: Justin Abrahms <justin@abrah.ms>
9ee5e41 to
1519df7
Compare
...al-provider/src/main/java/dev/openfeature/contrib/providers/jsonlogic/JsonlogicProvider.java
Outdated
Show resolved
Hide resolved
toddbaert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the exception of the metadata as @thiyagu06 pointed out: #241 (comment)
...val-provider/src/main/java/dev/openfeature/contrib/providers/jsonlogic/FileBasedFetcher.java
Outdated
Show resolved
Hide resolved
...al-provider/src/main/java/dev/openfeature/contrib/providers/jsonlogic/JsonlogicProvider.java
Outdated
Show resolved
Hide resolved
...val-provider/src/main/java/dev/openfeature/contrib/providers/jsonlogic/FileBasedFetcher.java
Outdated
Show resolved
Hide resolved
Kavindu-Dodan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with some comments :)
Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> Signed-off-by: Justin Abrahms <justin@abrah.ms>
Signed-off-by: Justin Abrahms <justin@abrah.ms>
Signed-off-by: Justin Abrahms <justin@abrah.ms>
Signed-off-by: Justin Abrahms <justin@abrah.ms>
Signed-off-by: Justin Abrahms <justin@abrah.ms>
…e#241) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR
This adds a new provider based on jsonlogic data format.
Related Issues
Refs open-feature/ofep#57
Follow-up Tasks
Haven't yet done the "convert into a value" yet, but this is a reasonable start.
How to test
The tests run. Feel free to provide additional test case suggestions.