fix: flagsmith string to double conversion issue (#1557) #1617
Conversation
Summary of ChangesHello @kushbatra, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical issue in the FlagsmithProvider where it failed to correctly interpret numeric flag values when they were returned as strings from the Flagsmith service. By enhancing the "convertValue" method, the provider can now seamlessly convert string-based double values into their appropriate "Double" type, ensuring robust and compatible flag evaluation across different Flagsmith environments. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively addresses an issue where string values from Flagsmith were not being correctly converted to Double types. The changes in FlagsmithProvider.java are well-implemented, and the addition of parameterized tests for the convertValue method is a great practice to ensure the logic is sound. I've included a few suggestions to further enhance the code: one to correct a minor bug in an error message, and another to extend the conversion logic to also handle integers, which would improve the provider's robustness. A corresponding test case for the integer conversion is also suggested.
| if (isPrimitive) { | ||
| if (expectedType == Double.class) { | ||
| if (value instanceof Double) { | ||
| flagValue = value; | ||
| } else if (value instanceof String) { | ||
| try { | ||
| flagValue = Double.parseDouble((String) value); | ||
| } catch (NumberFormatException e) { | ||
| throw new TypeMismatchError("Flag value string could not be parsed as Double: " + value); | ||
| } | ||
| } else { | ||
| throw new TypeMismatchError("Flag value had an unexpected type " | ||
| + (value != null ? value.getClass() : "null") + ", expected " + expectedType + "."); | ||
| } | ||
| } else { | ||
| flagValue = value; | ||
| } | ||
| } else { | ||
| flagValue = objectToValue(value); | ||
| } |
There was a problem hiding this comment.
This is a good fix for handling string-to-double conversion. To make the provider more robust and consistent, consider applying the same logic for string-to-integer conversion. Flagsmith might also return integer values as strings, and handling this case would be a great improvement.
if (isPrimitive) {
if (expectedType == Double.class) {
if (value instanceof Double) {
flagValue = value;
} else if (value instanceof String) {
try {
flagValue = Double.parseDouble((String) value);
} catch (NumberFormatException e) {
throw new TypeMismatchError("Flag value string could not be parsed as Double: " + value);
}
} else {
throw new TypeMismatchError("Flag value had an unexpected type "
+ (value != null ? value.getClass() : "null") + ", expected " + expectedType + ".");
}
} else if (expectedType == Integer.class) {
if (value instanceof Integer) {
flagValue = value;
} else if (value instanceof String) {
try {
flagValue = Integer.parseInt((String) value);
} catch (NumberFormatException e) {
throw new TypeMismatchError("Flag value string could not be parsed as Integer: " + value);
}
} else {
throw new TypeMismatchError("Flag value had an unexpected type "
+ (value != null ? value.getClass() : "null") + ", expected " + expectedType + ".");
}
} else {
flagValue = value;
}
} else {
flagValue = objectToValue(value);
}| throw new TypeMismatchError("Flag value had an unexpected type " | ||
| + (flagValue != null ? flagValue.getClass() : "null" + ", expected " + expectedType + ".")); |
There was a problem hiding this comment.
There's a minor bug in the construction of the error message here due to misplaced parentheses. When flagValue is not null, the message will be incomplete because the ", expected " + expectedType + "." part is inside the else branch of the ternary operator. To fix this, you should close the parenthesis for the ternary operator after "null".
throw new TypeMismatchError("Flag value had an unexpected type "
+ (flagValue != null ? flagValue.getClass() : "null") + ", expected " + expectedType + ".");| private static Stream<Arguments> convertValueArguments() { | ||
| return Stream.of( | ||
| Arguments.of(true, Boolean.class, true), | ||
| Arguments.of("test", String.class, "test"), | ||
| Arguments.of(123, Integer.class, 123), | ||
| Arguments.of(3.14, Double.class, 3.14), | ||
| Arguments.of("3.14", Double.class, 3.14)); | ||
| } |
There was a problem hiding this comment.
To accompany the suggested change for integer conversion in FlagsmithProvider.java, please add a test case to verify that a string value can be correctly converted to an Integer.
| private static Stream<Arguments> convertValueArguments() { | |
| return Stream.of( | |
| Arguments.of(true, Boolean.class, true), | |
| Arguments.of("test", String.class, "test"), | |
| Arguments.of(123, Integer.class, 123), | |
| Arguments.of(3.14, Double.class, 3.14), | |
| Arguments.of("3.14", Double.class, 3.14)); | |
| } | |
| private static Stream<Arguments> convertValueArguments() { | |
| return Stream.of( | |
| Arguments.of(true, Boolean.class, true), | |
| Arguments.of("test", String.class, "test"), | |
| Arguments.of(123, Integer.class, 123), | |
| Arguments.of("123", Integer.class, 123), | |
| Arguments.of(3.14, Double.class, 3.14), | |
| Arguments.of("3.14", Double.class, 3.14)); | |
| } |
3 participants
This PR
This PR fixes the issue where FlagsmithProvider.getDoubleDetails fails to parse flag values returned as strings (e.g., "42.42") from Flagsmith. Previously, the provider expected a java.lang.Double and returned an error if the value was a string. With this change, the provider will attempt to parse string values to Double when evaluating double flags, ensuring compatibility with Flagsmith environments that store numeric values as strings.
Related Issues
Fixes #1557