Skip to content

fix: flagsmith string to double conversion issue (#1557) #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: flagsmith string to double conversion issue (#1557) #1617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a290bb
fix: flagsmith string to double conversion issue (#1557)
kushbatra Oct 17, 2025
06046bd
Merge branch 'open-feature:main' into kb-open-feature-java-sdk-contri…
kushbatra Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 28 additions & 5 deletions ...lagsmith/src/main/java/dev.openfeature.contrib.providers.flagsmith/FlagsmithProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,19 +180,42 @@ private <T> ProviderEvaluation<T> buildEvaluation(
* @param expectedType the type we expect for this value
* @param <T> the type we want to convert to
* @return A converted object
* @throws TypeMismatchError if the value cannot be converted to the expected type
*/
@SuppressWarnings("unchecked")
private <T> T convertValue(Object value, Class<?> expectedType) {
boolean isPrimitive = expectedType == Boolean.class
|| expectedType == String.class
|| expectedType == Integer.class
|| expectedType == Double.class;
T flagValue = isPrimitive ? (T) value : (T) objectToValue(value);

if (flagValue.getClass() != expectedType) {
throw new TypeMismatchError(
"Flag value had an unexpected type " + flagValue.getClass() + ", expected " + expectedType + ".");
Object flagValue;
if (isPrimitive) {
if (expectedType == Double.class) {
if (value instanceof Double) {
flagValue = value;
} else if (value instanceof String) {
try {
flagValue = Double.parseDouble((String) value);
} catch (NumberFormatException e) {
throw new TypeMismatchError("Flag value string could not be parsed as Double: " + value);
}
} else {
throw new TypeMismatchError("Flag value had an unexpected type "
+ (value != null ? value.getClass() : "null") + ", expected " + expectedType + ".");
}
} else {
flagValue = value;
}
} else {
flagValue = objectToValue(value);
}
Comment on lines +193 to +212
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This is a good fix for handling string-to-double conversion. To make the provider more robust and consistent, consider applying the same logic for string-to-integer conversion. Flagsmith might also return integer values as strings, and handling this case would be a great improvement.

        if (isPrimitive) {
            if (expectedType == Double.class) {
                if (value instanceof Double) {
                    flagValue = value;
                } else if (value instanceof String) {
                    try {
                        flagValue = Double.parseDouble((String) value);
                    } catch (NumberFormatException e) {
                        throw new TypeMismatchError("Flag value string could not be parsed as Double: " + value);
                    }
                } else {
                    throw new TypeMismatchError("Flag value had an unexpected type "
                            + (value != null ? value.getClass() : "null") + ", expected " + expectedType + ".");
                }
            } else if (expectedType == Integer.class) {
                if (value instanceof Integer) {
                    flagValue = value;
                } else if (value instanceof String) {
                    try {
                        flagValue = Integer.parseInt((String) value);
                    } catch (NumberFormatException e) {
                        throw new TypeMismatchError("Flag value string could not be parsed as Integer: " + value);
                    }
                } else {
                    throw new TypeMismatchError("Flag value had an unexpected type "
                            + (value != null ? value.getClass() : "null") + ", expected " + expectedType + ".");
                }
            } else {
                flagValue = value;
            }
        } else {
            flagValue = objectToValue(value);
        }


if (!expectedType.isInstance(flagValue)) {
throw new TypeMismatchError("Flag value had an unexpected type "
+ (flagValue != null ? flagValue.getClass() : "null" + ", expected " + expectedType + "."));
Comment on lines +215 to +216
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's a minor bug in the construction of the error message here due to misplaced parentheses. When flagValue is not null, the message will be incomplete because the ", expected " + expectedType + "." part is inside the else branch of the ternary operator. To fix this, you should close the parenthesis for the ternary operator after "null".

            throw new TypeMismatchError("Flag value had an unexpected type "
                    + (flagValue != null ? flagValue.getClass() : "null") + ", expected " + expectedType + ".");

}
return flagValue;
return (T) flagValue;
}

/**
Expand Down
18 changes: 18 additions & 0 deletions ...mith/src/test/java/dev.openfeature.contrib.providers.flagsmith/FlagsmithProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,24 @@ void tearDown() throws IOException {
mockFlagsmithErrorServer.shutdown();
}

@ParameterizedTest
@MethodSource("convertValueArguments")
void testConvertValue(Object input, Class<?> expectedType, Object expected) throws Exception {
var method = flagsmithProvider.getClass().getDeclaredMethod("convertValue", Object.class, Class.class);
method.setAccessible(true);
Object result = method.invoke(flagsmithProvider, input, expectedType);
assertEquals(expected, result);
}

private static Stream<Arguments> convertValueArguments() {
return Stream.of(
Arguments.of(true, Boolean.class, true),
Arguments.of("test", String.class, "test"),
Arguments.of(123, Integer.class, 123),
Arguments.of(3.14, Double.class, 3.14),
Arguments.of("3.14", Double.class, 3.14));
}
Comment on lines +171 to +178
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To accompany the suggested change for integer conversion in FlagsmithProvider.java, please add a test case to verify that a string value can be correctly converted to an Integer.

Suggested change
private static Stream<Arguments> convertValueArguments() {
return Stream.of(
Arguments.of(true, Boolean.class, true),
Arguments.of("test", String.class, "test"),
Arguments.of(123, Integer.class, 123),
Arguments.of(3.14, Double.class, 3.14),
Arguments.of("3.14", Double.class, 3.14));
}
private static Stream<Arguments> convertValueArguments() {
return Stream.of(
Arguments.of(true, Boolean.class, true),
Arguments.of("test", String.class, "test"),
Arguments.of(123, Integer.class, 123),
Arguments.of("123", Integer.class, 123),
Arguments.of(3.14, Double.class, 3.14),
Arguments.of("3.14", Double.class, 3.14));
}


@Test
void shouldInitializeProviderWhenAllOptionsSet() {
HashMap<String, String> headers = new HashMap<String, String>() {
Expand Down