Skip to content

fix: remove snapshots #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2022
Merged

fix: remove snapshots #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
- name: Maven Verify Deploy
if: ${{ steps.release.outputs.releases_created }}
run: |
mvn --no-transfer-progress --batch-mode --settings release/m2-settings.xml verify deploy -Dversion.modifier=''
mvn --no-transfer-progress --batch-mode --settings release/m2-settings.xml verify deploy
env:
OSSRH_USERNAME: ${{ secrets.OSSRH_USERNAME }}
OSSRH_PASSWORD: ${{ secrets.OSSRH_PASSWORD }}
44 changes: 0 additions & 44 deletions .github/workflows/snapshot.yml
View file
Open in desktop

This file was deleted.

5 changes: 4 additions & 1 deletion .release-please-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
{}
{
"open-telemetry-hook": "0.0.1",
"flagd-provider": "0.0.1"
}
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
Java SDK contrib

To publish:
`mvn --no-transfer-progress --batch-mode --settings release/m2-settings.xml verify deploy -Dversion.modifier=''`
`mvn --no-transfer-progress --batch-mode --settings release/m2-settings.xml verify deploy -Dversion.modifier='-$GITHUB_SHA-SNAPSHOT'`
2 changes: 1 addition & 1 deletion flagd-provider/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
</parent>
<groupId>dev.openfeature.providers</groupId>
<artifactId>flagd</artifactId>
<version>0.0.1${version.modifier}</version>
<version>0.0.1</version>

<name>flagd</name>
<description>FlagD provider for Java</description>
Expand Down
2 changes: 1 addition & 1 deletion open-telemetry-hook/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
</parent>
<groupId>dev.openfeature.hooks</groupId>
<artifactId>otel</artifactId>
<version>0.0.1${version.modifier}</version>
<version>0.0.1</version>

<name>open-telemetry-hook</name>
<description>Open Telemetry Hook</description>
Expand Down
2 changes: 0 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
<properties>
<!-- skip deploy in parent (need to override this in submodules) -->
<maven.deploy.skip>true</maven.deploy.skip>
<!-- during releases, we override this to make it empty -->
<version.modifier>-${env.GITHUB_SHA}-SNAPSHOT</version.modifier>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>${maven.compiler.source}</maven.compiler.target>
<junit.jupiter.version>5.8.1</junit.jupiter.version>
Expand Down