Skip to content

fix: keep distributionManagement in flattened pom#1958

Merged
toddbaert merged 1 commit into
mainfrom
fix/keep-distmgmt-in-flatten
Jun 5, 2026
Merged

fix: keep distributionManagement in flattened pom#1958
toddbaert merged 1 commit into
mainfrom
fix/keep-distmgmt-in-flatten

Conversation

@toddbaert
Copy link
Copy Markdown
Member

Follow-up to #1951. Flatten was stripping <distributionManagement>, which broke the snapshot deploy in on-merge (central-publishing falls back to it for the snapshots URL).

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert requested review from a team as code owners June 5, 2026 14:50
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pom.xml configuration to preserve the distributionManagement element during POM flattening, ensuring that the central-publishing plugin can resolve the snapshot repository during deployment. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 5, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.27%. Comparing base (42418c1) to head (b7e324f).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1958      +/-   ##
============================================
+ Coverage     92.27%   93.27%   +1.00%     
- Complexity      653      656       +3     
============================================
  Files            59       59              
  Lines          1592     1592              
  Branches        179      179              
============================================
+ Hits           1469     1485      +16     
+ Misses           76       62      -14     
+ Partials         47       45       -2     
Flag Coverage Δ
unittests 93.27% <ø> (+1.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@toddbaert toddbaert merged commit 08ce6d0 into main Jun 5, 2026
10 checks passed
@toddbaert toddbaert deleted the fix/keep-distmgmt-in-flatten branch June 5, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant