Some improvements to EvaluationContext #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .collect(Collectors.toMap(Map.Entry::getKey, e -> (Boolean)e.getValue())) | ||
| ); | ||
| // Hmmm, this won't work as we already have a string type. | ||
| // I would recommend changing the type to Map<String, JsonNode> from Jackson |
Member
There was a problem hiding this comment.
I'm a jackson newbie, but my understanding is that jsonnode's are an immutable json tree structure. That seems fine to me for this.
Member
|
@agentgonzo, this seems like a nice change. Would you be able to get it into a mergeable state? @justinabrahms any concerns about this? |
Member
|
@beeme1mr No strong concerns. There are backwards incompatibilities here, which I don't love, but it's still early days so.. seems inevitable? |
Member
|
@agentgonzo Do you have an intent to finish up this PR? Or should I close it? |
Member
|
Closing due to inactivity. |
Member
Author
|
This completely fell off my radar. I'm away for a week, but will try to get a decent mergeable PR ready when I get back |
Member
|
@agentgonzo sounds good! Feel free to reopen the PR when it's ready. |
justinabrahms
added a commit
that referenced
this pull request
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More of a suggestion/discussion than a real PR.
@justinabrahms , let me know your thoughts.