-
Notifications
You must be signed in to change notification settings - Fork 91
chore: add kubecon na 2025 to announcement banner #1271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for openfeature ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @thisisobate, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the website's front-facing information by enabling and configuring an announcement banner to advertise KubeCon + CloudNativeCon North America 2025. Concurrently, it ensures that the site's external content, specifically for community and specification details, is current by updating the respective Git submodules to their latest versions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds an announcement banner for KubeCon NA 2025. The implementation is mostly correct, but I found an HTML syntax error in the banner's content string that could lead to rendering issues. I've provided a suggestion to fix the invalid HTML.
Signed-off-by: thisisobate <obasiuche62@gmail.com>
da411a3 to
1823127
Compare
Signed-off-by: thisisobate <obasiuche62@gmail.com>
084d638 to
1416b9d
Compare
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
|
Thanks for the approval @beeme1mr ; feel free to merge! 🥳 |
Fixes #1270