-
Notifications
You must be signed in to change notification settings - Fork 91
feat: add-rust-provider-documentation #1321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add-rust-provider-documentation #1321
Conversation
Signed-off-by: wadii <wadii.zaim@flagsmith.com>
✅ Deploy Preview for openfeature ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @Zaimwa9, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Flagsmith Rust provider into the OpenFeature ecosystem documentation. By adding this new entry, the PR enhances the discoverability of official Rust-based feature flag solutions for developers, ensuring the ecosystem list remains comprehensive and up-to-date with available implementations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
@jbovet Sorry for the mess, here is the new PR 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the Flagsmith provider for Rust to the ecosystem list. The change is straightforward, adding a new entry to the technologies array in src/datasets/providers/flagsmith.ts. The new data entry is consistent with the structure of existing providers and follows the required Provider type definition. The code change is correct and I have no further feedback.
jbovet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @Zaimwa9
## This PR Adds Flagsmith rust provider to the ecosystem list ### Related Issues Dependent on open-feature/rust-sdk-contrib#82 Signed-off-by: wadii <wadii.zaim@flagsmith.com>
This PR
Adds Flagsmith rust provider to the ecosystem list
Related Issues
Dependent on open-feature/rust-sdk-contrib#82