fix: various custom operator conformance fixes#386
fix: various custom operator conformance fixes#386toddbaert merged 7 commits intoopen-feature:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the test-harness subproject, introduces partial version support in SemVer parsing by padding with zeros, and changes the return value of string comparisons for non-string inputs from False to None. The review feedback identifies a bug in the version padding logic that breaks versions with suffixes, notes that existing tests need updates to reflect the new return types, and suggests maintaining backward compatibility for the renamed parse_version function.
| ends_with, | ||
| fractional, | ||
| parse_version, | ||
| normalize_version, |
There was a problem hiding this comment.
Renaming parse_version to normalize_version is a breaking change for consumers of this module. Given that this file is explicitly intended for backward compatibility (as noted in the header comment), it should continue to export parse_version as an alias.
| normalize_version, | |
| normalize_version, | |
| normalize_version as parse_version, |
There was a problem hiding this comment.
Not sure about this one, is this necessary? I changed it locally but the pre-commit hook reverted it :D
There was a problem hiding this comment.
i think it is is ok. this is an internal function, I don't think anyone relied on it. just to be a bit more carful let's add it as a change in the description.
There was a problem hiding this comment.
So you mean that we can keep it as it is right now? Sorry, I'm not entirely sure from your answer.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
==========================================
+ Coverage 96.14% 96.20% +0.06%
==========================================
Files 47 47
Lines 1737 1741 +4
==========================================
+ Hits 1670 1675 +5
+ Misses 67 66 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4cbf9f0 to
ee5e7b6
Compare
Signed-off-by: Lea Konvalinka <lea.konvalinka@dynatrace.com>
Signed-off-by: Lea Konvalinka <lea.konvalinka@dynatrace.com>
Signed-off-by: Lea Konvalinka <lea.konvalinka@dynatrace.com>
Signed-off-by: Lea Konvalinka <lea.konvalinka@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
6c4445d to
175d0a2
Compare
* support V prefix in semver * return null on errors in semver, ends_with, and fractional (already existed on starts_with) * fix fractional fallback when total weight is zero Fixes: #1942 --- Related: * open-feature/java-sdk-contrib#1778 * open-feature/js-sdk-contrib#1519 * open-feature/dotnet-sdk-contrib#635 * open-feature/python-sdk-contrib#386 --------- Signed-off-by: Lea Konvalinka <lea.konvalinka@dynatrace.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
parse_versiontonormalize_versionFixes: #379
Related: