-
Notifications
You must be signed in to change notification settings - Fork 23
chore: upgrade mypy and ruff #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: gruebel <anton.gruebel@gmail.com>
Summary of ChangesHello @gruebel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintenance by upgrading development tools to their latest stable versions. It updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 21 21
Lines 1057 1057
=======================================
Hits 998 998
Misses 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades mypy and ruff. While the individual file changes for upgrading dependencies and configurations are correct, the process seems incomplete, leading to inconsistencies.
Specifically:
- The
uv.lockfile is not fully synchronized with the changes inpyproject.tomlfiles. The dev dependencies foropenfeature-hooks-opentelemetryandopenfeature-provider-env-varare not updated in the lock file. - The root
pyproject.tomlstill references the oldmypyversion (mypy[faster-cache]>=1.17.0,<2.0.0).
These inconsistencies can cause problems for other developers. To resolve this, please update the root pyproject.toml and then regenerate the uv.lock file for the entire workspace.
This PR
mypywas already upgraded, but now it properly uses the new configuration