Skip to content

Conversation

@gruebel
Copy link
Member

@gruebel gruebel commented Sep 25, 2025

This PR

  • mypy was already upgraded, but now it properly uses the new configuration

Signed-off-by: gruebel <anton.gruebel@gmail.com>
@gruebel gruebel requested review from a team as code owners September 25, 2025 20:56
@gemini-code-assist
Copy link

Summary of Changes

Hello @gruebel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on maintenance by upgrading development tools to their latest stable versions. It updates the ruff linter and pre-commit hooks, and significantly upgrades mypy to version 1.18.0 across several project modules. This mypy upgrade also includes adjustments to its configuration to align with upcoming defaults and improve caching mechanisms, ensuring type checking remains robust and efficient.

Highlights

  • Ruff and Pre-commit Hooks Upgrades: The ruff-pre-commit hook has been updated from v0.12.7 to v0.13.2, and the general pre-commit-hooks have been upgraded from v5.0.0 to v6.0.0.
  • Mypy Version Update: The mypy dependency across multiple pyproject.toml files and the uv.lock file has been updated to 1.18.0, removing the faster-cache extra.
  • Mypy Configuration Enhancements: New mypy configuration options, allow_redefinition_new = true and fixed_format_cache = true, have been added to align with upcoming defaults and improve caching. A comment was also added to local_partial_types = true noting its future default status.
  • Dependency Lock File Synchronization: The uv.lock file has been updated to reflect the new mypy version and configuration changes, and also includes an update for openfeature-provider-ofrep from version 0.1.1 to 0.2.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.41%. Comparing base (65ea9dd) to head (1b7c524).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files          21       21           
  Lines        1057     1057           
=======================================
  Hits          998      998           
  Misses         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades mypy and ruff. While the individual file changes for upgrading dependencies and configurations are correct, the process seems incomplete, leading to inconsistencies.

Specifically:

  • The uv.lock file is not fully synchronized with the changes in pyproject.toml files. The dev dependencies for openfeature-hooks-opentelemetry and openfeature-provider-env-var are not updated in the lock file.
  • The root pyproject.toml still references the old mypy version (mypy[faster-cache]>=1.17.0,<2.0.0).

These inconsistencies can cause problems for other developers. To resolve this, please update the root pyproject.toml and then regenerate the uv.lock file for the entire workspace.

@gruebel gruebel merged commit fe8130a into main Sep 26, 2025
37 checks passed
@gruebel gruebel deleted the upgrade-ruff branch September 26, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants