Skip to content

ci: add generated protobuf files to sdist and wheel #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ci: add generated protobuf files to sdist and wheel #46

wants to merge 1 commit into from

Conversation

@gruebel
Copy link
Member

@gruebel gruebel commented Feb 22, 2024

This PR

  • leveraged hatch-build-scripts plugin to run the gen_protos.sh
  • fixed the gen_protos.sh file to correctly the paths
  • had to add ignore-vcs = true to make it all work, otherwise hatch just ignored the generated files

@gruebel
add generated protobuf files to sdist and wheel
79f1def 
Signed-off-by: gruebel <anton.gruebel@gmail.com>
@gruebel gruebel requested a review from a team as a code owner February 22, 2024 21:57
@federicobond
Copy link
Member

federicobond commented Feb 23, 2024

Closing this in favor of #45, committing the generated files for now. Thank you @gruebel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gruebel @federicobond