Skip to content

Ensure error hooks are run when provider returns FlagResolutionDetails with error code #290

@federicobond

Description

@federicobond

Currently, in error situations, it's possible for providers to return FlagResolutionDetails objects with errors set, OR throw. However, the SDK only runs the error hooks when an error is thrown.

It should either be impossible to return an object indicating an error (we'd need a new type) or the SDK should check the returned object and run the error hooks if an error is indicated.

See

error_hooks(flag_type, hook_context, err, reversed_merged_hooks, hook_hints)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingcontribfestA good issue for Contribfest KubeCon EU '24good first issueGood for newcomers

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions