Skip to content

Conversation

@gruebel
Copy link
Member

@gruebel gruebel commented Jan 6, 2024

This PR

  • excludes the tests from being scanned by CodeQL, which is not needed and improves scanning time
    • from ~1:35 to now ~1:18 a small improvement, which will pay off over time with more tests added 🙂
  • added missing permissions restrictions for the GHA workflow files

Signed-off-by: gruebel <anton.gruebel@gmail.com>
@codecov
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b6204d) 93.45% compared to head (bf55d97) 93.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   93.45%   93.45%           
=======================================
  Files          16       16           
  Lines         443      443           
=======================================
  Hits          414      414           
  Misses         29       29           
Flag Coverage Δ
unittests 93.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gruebel gruebel changed the title ignore tests in CodeQL scan and add missing permission restrictions ci: ignore tests in CodeQL scan and add missing permission restrictions Jan 6, 2024
@federicobond federicobond merged commit 49aae78 into open-feature:main Jan 6, 2024
@gruebel gruebel deleted the improve-workflow branch January 6, 2024 14:49
kikihakiem pushed a commit to ResalApps/openfeature-python-sdk that referenced this pull request Aug 28, 2025
…spec digest to f014806 (open-feature#253)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants