Skip to content

feat: make return value not optional in provider API functions #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2024
Merged

feat: make return value not optional in provider API functions #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8329e89
feat: make return value not optional in provider API functions
federicobond Feb 3, 2024
c76bc8a
Merge branch 'main' into provider-not-optional
federicobond Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openfeature/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ def set_provider(provider: FeatureProvider) -> None:
provider.initialize(_evaluation_context)


def get_provider() -> typing.Optional[FeatureProvider]:
def get_provider() -> FeatureProvider:
global _provider
return _provider


def get_provider_metadata() -> typing.Optional[Metadata]:
def get_provider_metadata() -> Metadata:
global _provider
return _provider.get_metadata()

Expand Down
5 changes: 0 additions & 5 deletions openfeature/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
error_hooks,
)
from openfeature.provider import FeatureProvider
from openfeature.provider.no_op_provider import NoOpProvider

logger = logging.getLogger("openfeature")

Expand Down Expand Up @@ -374,10 +373,6 @@ def _create_provider_evaluation(
evaluation_context,
)

if not self.provider:
logger.info("No provider configured, using no-op provider.")
self.provider = NoOpProvider()

get_details_callables: typing.Mapping[FlagType, GetDetailCallable] = {
FlagType.BOOLEAN: self.provider.resolve_boolean_details,
FlagType.INTEGER: self.provider.resolve_integer_details,
Expand Down