Skip to content

Conversation

@gruebel
Copy link
Member

@gruebel gruebel commented Mar 20, 2024

Signed-off-by: gruebel <anton.gruebel@gmail.com>
@codecov
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.10%. Comparing base (47ae16c) to head (318f40e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   94.77%   97.10%   +2.33%     
==========================================
  Files          20       27       +7     
  Lines         651     1176     +525     
==========================================
+ Hits          617     1142     +525     
  Misses         34       34              
Flag Coverage Δ
unittests 97.10% <ø> (+2.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@federicobond
Copy link
Member

Nice work! Let's derisk the current release by waiting to merge until after we release event support 🙏

@federicobond
Copy link
Member

Sorry for the delay! Looks good to me. Only wondering if we should pin the test dependencies and let renovate handle updates.

@gruebel
Copy link
Member Author

gruebel commented Apr 5, 2024

Sorry for the delay! Looks good to me. Only wondering if we should pin the test dependencies and let renovate handle updates.

I have no problem with pinning them, but I couldn't find any info about renovate supporting hatch envs, therefore I'm hesitant to really pin them.

@federicobond
Copy link
Member

Ah makes sense, I only thought about the dependencies being in a pyproject.toml file, but renovate needs to support env dependencies explicitly.

@federicobond federicobond merged commit 9ba82e3 into open-feature:main Apr 5, 2024
@gruebel gruebel deleted the use-hatch branch April 5, 2024 07:09
kikihakiem pushed a commit to ResalApps/openfeature-python-sdk that referenced this pull request Aug 28, 2025
…penfeature/test-harness to v2.11.1 (open-feature#297)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use hatch for packaging and dependency management Implement wrapper for packaging and dependency management

2 participants