-
Notifications
You must be signed in to change notification settings - Fork 30
chore: update mypy and ruff #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: gruebel <anton.gruebel@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @gruebel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on maintaining the project's development environment by updating various Python tools and libraries to their latest versions. This ensures compatibility, leverages new features, and incorporates bug fixes from these tools, while also refining a small part of the test suite for better code hygiene.
Highlights
- Dependency Updates: Updated several development dependencies and tools, including mypy, ruff, pre-commit hooks, behave, coverage, pytest, and virtualenv, as reflected in the .pre-commit-config.yaml and uv.lock files.
- Mypy Configuration: Added new configuration options, 'allow_redefinition_new' and 'fixed_format_cache', to the mypy settings in pyproject.toml to align with newer mypy versions.
- Test Code Refinement: Made a minor change in tests/test_client.py to use the underscore '_' convention for an unused variable, improving code clarity.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
=======================================
Coverage 97.85% 97.85%
=======================================
Files 39 39
Lines 1822 1822
=======================================
Hits 1783 1783
Misses 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates mypy, ruff, and other development dependencies. The changes across .pre-commit-config.yaml, pyproject.toml, and uv.lock are consistent with this goal. The minor code fix in tests/test_client.py is a good readability improvement. The updates are well-contained and help keep the project's tooling up-to-date. I've reviewed the changes and found no issues. This looks good to merge.
This PR
uv.lockfile