-
Notifications
You must be signed in to change notification settings - Fork 30
feat: defaults to NoOpProvider #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ensures a provider will always be returned Signed-off-by: Tom Carrio <tom@carrio.dev>
Signed-off-by: Tom Carrio <tom@carrio.dev>
|
Updated tests 👍 |
Codecov Report
@@ Coverage Diff @@
## main #66 +/- ##
==========================================
- Coverage 92.69% 92.66% -0.03%
==========================================
Files 19 19
Lines 342 341 -1
==========================================
- Hits 317 316 -1
Misses 25 25
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
The |
beeme1mr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one comment but overall looks good.
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Tom Carrio <tom@carrio.dev>
…ure#66) Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR
Related Issues
Fixes #1234523
Notes
This fixes an issue with spec compliance
Follow-up Tasks
- TestsHow to test
Given you have not set a provider
When you retrieve an OpenFeature client
Then an error will not be raised