Skip to content

feat: Add Flipt provider gem with basic implementation #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 14, 2025
Merged

feat: Add Flipt provider gem with basic implementation #51

merged 8 commits into from
Apr 14, 2025

Conversation

@falghi
Copy link
Contributor

@falghi falghi commented Mar 29, 2025 •
edited
Loading

This PR

  • Adds a new gem project: Flipt provider
  • Adds basic implementation for feature flags evaluation

Some references:

  1. https://github.com/open-feature/js-sdk-contrib/blob/main/libs/providers/flipt/src/lib/flipt-provider.ts
  2. https://docs.flipt.io/reference/overview

Follow-up Tasks

  • Initial release of Flipt provider gem

How to test

  • Pull this gem locally and test if it works in a Ruby application
  • Tests are passed

Screenshot 2025-04-12 at 11 40 59

beeme1mr
beeme1mr approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start! Thanks for the PR.

@beeme1mr beeme1mr requested a review from markphelps April 8, 2025 13:26
@beeme1mr
Copy link
Member

beeme1mr commented Apr 8, 2025

@falghi please sign off your previous commits when you have a moment. It's a requirement from the CNCF.

falghi added 4 commits April 9, 2025 10:51
@falghi
feat: Add initial Flipt Provider
9818e1e 
Signed-off-by: Firdaus Al Ghifari <firdaus.alghifari@gmail.com>
@falghi
test: Add unit tests for Flipt Provider
9076504 
Signed-off-by: Firdaus Al Ghifari <firdaus.alghifari@gmail.com>
@falghi
ci: Add ci for flipt provider
6cef975 
Signed-off-by: Firdaus Al Ghifari <firdaus.alghifari@gmail.com>
@falghi
chores: Add flipt provider to code-workspace
503ce10 
Signed-off-by: Firdaus Al Ghifari <firdaus.alghifari@gmail.com>
@falghi falghi force-pushed the alghi/add-flipt-provider branch from 64289af to 503ce10 Compare April 9, 2025 01:54
@falghi
Copy link
Contributor Author

falghi commented Apr 9, 2025

@beeme1mr Done! Signed all my commits ✅

maxveldink
maxveldink approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@maxveldink maxveldink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers from me; this looks like a great addition 👏🏻

falghi added 3 commits April 12, 2025 11:31
@falghi
docs: update flipt README.md with authentication example
76a05ce 
Signed-off-by: Firdaus Al Ghifari <firdaus.alghifari@gmail.com>
@falghi
refactor: move client initialization to constructor method
6913d1c 
Signed-off-by: Firdaus Al Ghifari <firdaus.alghifari@gmail.com>
@falghi
refactor: remove unnecessary memoization on constructor
92d68e8 
Signed-off-by: Firdaus Al Ghifari <firdaus.alghifari@gmail.com>
@beeme1mr
Copy link
Member

beeme1mr commented Apr 12, 2025

Hi @falghi , I'll merge this pr and release the Gem on Monday. Thanks!

@falghi
fix: flipt ruby provider client initialization logic
a5223bc 
Signed-off-by: Firdaus Al Ghifari <firdaus.alghifari@gmail.com>
@falghi
Copy link
Contributor Author

falghi commented Apr 12, 2025

@beeme1mr Thanks a lot! I'm looking forward to that ✨

I added one minor fix by the way a5223bc and retested everything on my local 🙏 It's good to go

maxveldink
maxveldink approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@maxveldink maxveldink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@beeme1mr beeme1mr merged commit 8e0ae7c into open-feature:main Apr 14, 2025
14 checks passed
@openfeaturebot openfeaturebot mentioned this pull request Apr 14, 2025
Merged
@beeme1mr
Copy link
Member

beeme1mr commented Apr 14, 2025 •
edited
Loading

Greetings @falghi, I was hoping to release the Flipt provider today but the tests are failing because the Gemfile.lock seems to be outdated. Could you please take a look when you have a moment?

https://github.com/open-feature/ruby-sdk-contrib/actions/runs/14451275710/job/40524345993?pr=54

By the way, would you be interested in joining the OpenFeature org? It's the first step in our contributing ladder and would make it easy to collaborate on GitHub.

@falghi
Copy link
Contributor Author

falghi commented Apr 15, 2025

@beeme1mr
Sure! I've created a fix in this PR: #55 . Please take a look when you have a moment 🙇

By the way, would you be interested in joining the OpenFeature org? It's the first step in our contributing ladder and would make it easy to collaborate on GitHub.

That would be interesting. I'd love to join

@beeme1mr beeme1mr mentioned this pull request Apr 15, 2025
Merged
beeme1mr pushed a commit that referenced this pull request Apr 16, 2025
@openfeaturebot @falghi
chore(main): release openfeature-flipt-provider 0.0.2 (#54)
bb5480c 
🤖 I have created a release *beep* *boop*
---


##
[0.0.2](openfeature-flipt-provider-v0.0.1...openfeature-flipt-provider/v0.0.2)
(2025-04-15)


### 🐛 Bug Fixes

* Update Gemfile.lock on flipt provider
([#55](#55))
([fd79d7b](fd79d7b))


### ✨ New Features

* Add Flipt provider gem with basic implementation
([#51](#51))
([8e0ae7c](8e0ae7c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Signed-off-by: Firdaus Al Ghifari <firdaus.alghifari@gmail.com>
Co-authored-by: Firdaus Al Ghifari <34407426+falghi@users.noreply.github.com>
Zaimwa9 pushed a commit to Zaimwa9/ruby-sdk-contrib that referenced this pull request Nov 26, 2025
@falghi @Zaimwa9
feat: Add Flipt provider gem with basic implementation (open-feature#51)
665500f 
Signed-off-by: Firdaus Al Ghifari <firdaus.alghifari@gmail.com>
Signed-off-by: wadii <wadii.zaim@flagsmith.com>
Zaimwa9 pushed a commit to Zaimwa9/ruby-sdk-contrib that referenced this pull request Nov 26, 2025
@openfeaturebot @falghi @Zaimwa9
chore(main): release openfeature-flipt-provider 0.0.2 (open-feature#54)
7e78ac1 
🤖 I have created a release *beep* *boop*
---

##
[0.0.2](open-feature/ruby-sdk-contrib@openfeature-flipt-provider-v0.0.1...openfeature-flipt-provider/v0.0.2)
(2025-04-15)

### 🐛 Bug Fixes

* Update Gemfile.lock on flipt provider
([open-feature#55](open-feature#55))
([fd79d7b](open-feature@fd79d7b))

### ✨ New Features

* Add Flipt provider gem with basic implementation
([open-feature#51](open-feature#51))
([8e0ae7c](open-feature@8e0ae7c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Signed-off-by: Firdaus Al Ghifari <firdaus.alghifari@gmail.com>
Co-authored-by: Firdaus Al Ghifari <34407426+falghi@users.noreply.github.com>
Signed-off-by: wadii <wadii.zaim@flagsmith.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@maxveldink maxveldink maxveldink approved these changes

@markphelps markphelps Awaiting requested review from markphelps

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@falghi @beeme1mr @maxveldink