fix(openfeature-go-feature-flag-provider): fallback to sdkDefault if reason is DISABLED

[doriandekoning]

This PR

Currently, when go-feature-flags has a disabled flag it returns a response in the following format: {"key":"my_flag","value":"thisisadefaultvaluethatItest1233%%","reason":"DISABLED","variant":"SdkDefault"}. This thisisadefault... comes directly from go-feature-flags. The client package returns this, but sdkDefault makes more sense.

https://github.com/thomaspoignant/go-feature-flag/blob/de4d46dd7d513da32a9c67f0c38ae577d51ff6bd/cmd/relayproxy/ofrep/evaluate.go#L95C19-L95C51

[gemini-code-assist]

Summary of Changes

Hello @doriandekoning, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an inconsistency in how the OpenFeature GoFeatureFlag provider handles disabled flags. Previously, when a flag was disabled by the GoFeatureFlag service, the provider would return a value from the service rather than the expected SDK default. The changes ensure that the provider now correctly falls back to the SDK's default value when a flag is disabled, improving reliability and adherence to OpenFeature specifications.

Highlights

• Bug Fix: Disabled Flag Handling: The pull request addresses an issue where the openfeature-go-feature-flag-provider was not correctly handling flags that were disabled by the go-feature-flags service. Previously, it would return a value provided by go-feature-flags even when the flag was explicitly disabled, which was inconsistent with the expected behavior of falling back to the SDK's default value.
• Fallback to SDK Default: The provider now explicitly checks if the reason for a flag evaluation is DISABLED. If so, it ensures that the SDK::Provider::ResolutionDetails returns the default_value provided by the OpenFeature SDK, along with the DISABLED reason, aligning with standard feature flag practices.
• New Test Case: A new test case has been added to provider_spec.rb to verify this corrected behavior, ensuring that when a flag is disabled by the go-feature-flags service, the OpenFeature provider correctly returns the default_value.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly implements the fallback to the SDK's default value when the go-feature-flag provider returns a DISABLED reason. The logic is sound and a corresponding test case has been added to ensure this behavior. My review includes one suggestion to improve the clarity and consistency of the new test case.