feat: OpenFeature::SDK.configure #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Nichols <josh.nichols@gusto.com>
Signed-off-by: Josh Nichols <josh.nichols@gusto.com>
Signed-off-by: Josh Nichols <josh.nichols@gusto.com>
josecolella
approved these changes
Dec 14, 2022
Collaborator
josecolella
left a comment
josecolella
left a comment
There was a problem hiding this comment.
Thanks @technicalpickles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
This adds the
OpenFeature::SDK.configuremethod listed in README.mdAll the functionality is already implemented in
OpenFeature::SDK::API, so this just delegates to it usingmethod_missing. And it's siblingrespond_to_missing?Related Issues
#40 which helps point out what we're missing from an initial implementation
Notes
I am kinda wondering if there's value in splitting out
OpenFeature::SDK::APIvsOpenFeature::SDK. I went with what was easiest for now.Follow-up Tasks
How to test