Conversation
Summary of ChangesHello @toddbaert, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the OpenFeature specification by introducing the concept of isolated API instances. This change addresses advanced use cases such as micro-frontends, dependency injection, and testing scenarios, where independent API instances with fully isolated state are required. It defines how these instances should be created, behave, and manage their associated providers, moving beyond the default global singleton model. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces the concept of "Isolated API Instances" to the OpenFeature specification. It includes a new glossary entry and a detailed section outlining the requirements for creating and managing these independent API instances. The changes are well-documented, providing clear rationale, examples, and cross-references to other parts of the specification. The addition addresses advanced use cases such as micro-frontends and dependency injection, enhancing the flexibility of the OpenFeature API.
d40726d to
85bb12b
Compare
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
85bb12b to
d16ebc8
Compare
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
ce29fb2 to
d48f002
Compare
Adds spec for isolated instances.
Resolves: #359
Relevant work: