Conversation
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
🚀 OpenFeature Manifest Comparison (validate-flags)Warning Remote Push Preview - The following changes will be applied to the remote flag service ( 📊 Change Summary
📋 View detailed changes🟢 Flags That Will Be Added (1)🟢 🔄 View manifest diff@@ -1,20 +1,15 @@
{
"$schema": "https://raw.githubusercontent.com/open-feature/cli/refs/heads/main/schema/v0/flag-manifest.json",
"flags": {
- "free-shipping-banner": {
- "flagType": "boolean",
- "description": "Controls the free shipping banner on the website. SHOP-4287",
- "defaultValue": false
- },
"offer-free-shipping": {
- "flagType": "boolean",
+ "defaultValue": false,
"description": "Add free shipping to the UI.",
- "defaultValue": false
+ "flagType": "boolean"
},
"sticky-header": {
- "flagType": "boolean",
+ "defaultValue": false,
"description": "Make the header stay at the top of the page while scrolling.",
- "defaultValue": false
+ "flagType": "boolean"
},
"use-distributed-db": {
"defaultValue": true,💡 This preview shows what will change in the remote flag service when you push your local manifest This comment is automatically updated on each push |
There was a problem hiding this comment.
Code Review
This pull request introduces a new feature flag free-shipping-banner and refactors the flag definitions and their usage across the application. The changes are a good improvement, especially with the introduction of FlagKeys to avoid magic strings. I've identified a few issues that should be addressed to improve the code quality: an obsolete flag definition that should be removed, and a couple of inconsistencies in default values within the generated hooks. I've also pointed out a minor formatting issue in the generated JSDoc comments.
No description provided.