Skip to content

Issue1482 Open Modelica errors and syntax warnings#1484

Merged
LoneMeertens merged 9 commits into
masterfrom
issue1482_OMSyntaxErrors
Apr 22, 2026
Merged

Issue1482 Open Modelica errors and syntax warnings#1484
LoneMeertens merged 9 commits into
masterfrom
issue1482_OMSyntaxErrors

Conversation

@LoneMeertens
Copy link
Copy Markdown
Contributor

Fix OpenModelica Syntax Errors in PPD12 and PVT Validation Models

This PR resolves syntax and parsing issues reported in #1482, which prevented IDEAS v4.0.0 (master) from loading in OpenModelica 1.25.5. All changes are backward‑compatible with Dymola.

Summary of Fixes

  • PPD12 Structure.mo: removed invalid escape sequences (\e, \<) in the Documentation annotation that caused OpenModelica lexer warnings.
  • PVT validation models: removed unsupported break statements from
    • Fluid/PVTCollectors/Validation/PVT_UI/PVTQuasiDynamicCollectorValidation.mo
    • Fluid/PVTCollectors/Validation/PVT_UN/PVTQuasiDynamicCollectorValidation.mo
  • R410A package.order: removed duplicate entries (A, B, C) which referenced protected constants not meant to appear in package.order.

Impact

  • IDEAS loads cleanly in OpenModelica 1.25.5 without syntax or parser warnings.
  • Dymola compatibility is preserved.
  • PVTCollectors package becomes usable again in OM (relevant for ongoing work in Issue1473 pvt validation ext #1481).
  • No model behaviour or numerical results are affected.

@LoneMeertens LoneMeertens self-assigned this Mar 31, 2026
@LoneMeertens
Copy link
Copy Markdown
Contributor Author

@lucasverleyen Could you take a quick look at this PR? If everything is fine, can we merge it?

Copy link
Copy Markdown
Member

@lucasverleyen lucasverleyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks fine!

One general comment: you did not include any revision history in the models. Might be good and helpful for others if you add the revision history explaining what you changed to be OM compatible (or referring to the issue/PR in GitHub).

Other comments concert details and are rather suggestions for the future.

Thanks a lot for addressing this issue! :)

Comment thread IDEAS/Fluid/PVTCollectors/Validation/PVT_UI/PVTQuasiDynamicCollectorValidation.mo Outdated
Comment thread IDEAS/Fluid/PVTCollectors/Validation/PVT_UN/PVT_UN_Electrical.mo
Comment thread IDEAS/Fluid/PVTCollectors/Validation/PVT_UN/PVT_UN_Thermal.mo
Comment on lines -21 to -23
A
B
C
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am right, this change has nothing to do with syntax, but with the duplicate names in the .order file (which can raise an issue in OMEdit)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, indeed. It gave a warning in OM.

LoneMeertens and others added 4 commits April 21, 2026 12:59
…lectorValidation.mo

Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
…DynamicCollectorValidation.mo

Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
@LoneMeertens LoneMeertens merged commit 272d82a into master Apr 22, 2026
2 checks passed
@LoneMeertens LoneMeertens deleted the issue1482_OMSyntaxErrors branch April 22, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants