[issue-1617] - Simplify service create or update#1648
Merged
pmbrull merged 1 commit intoopen-metadata:mainfrom Dec 9, 2021
Merged
[issue-1617] - Simplify service create or update#1648pmbrull merged 1 commit intoopen-metadata:mainfrom
pmbrull merged 1 commit intoopen-metadata:mainfrom
Conversation
harshach
approved these changes
Dec 9, 2021
omriAl
pushed a commit
to omriAl/OpenMetadata
that referenced
this pull request
Dec 14, 2021
harshach
added a commit
that referenced
this pull request
Mar 17, 2026
…ce tracking
Add a new /v1/changeSummary/{entityType}/{id|name/fqn} endpoint that
returns per-field change metadata (who changed it, source type, timestamp).
Supports fieldPrefix filtering for column-level queries on large tables
and limit/offset pagination.
UI additions:
- DescriptionSourceBadge component showing AI badge on AI-generated descriptions
- useChangeSummary hook for fetching change summary data
- changeSummaryAPI REST client
- "accepted-by" translation key
Integration tests added to BaseEntityIT covering all entity types:
get by ID, get by FQN, fieldPrefix filtering, pagination, and 404 cases.
Closes #1648
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
harshach
added a commit
that referenced
this pull request
Apr 10, 2026
* Add changeSummary API endpoint and UI components for description source tracking
Add a new /v1/changeSummary/{entityType}/{id|name/fqn} endpoint that
returns per-field change metadata (who changed it, source type, timestamp).
Supports fieldPrefix filtering for column-level queries on large tables
and limit/offset pagination.
UI additions:
- DescriptionSourceBadge component showing AI badge on AI-generated descriptions
- useChangeSummary hook for fetching change summary data
- changeSummaryAPI REST client
- "accepted-by" translation key
Integration tests added to BaseEntityIT covering all entity types:
get by ID, get by FQN, fieldPrefix filtering, pagination, and 404 cases.
Closes #1648
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Fix checkstyle
* Integrate DescriptionSourceBadge into UI and address PR review comments
- Add authorization checks (VIEW_BASIC) to ChangeSummaryResource endpoints
- Fix pagination defaults and simplify pagination logic
- Remove silent try-catch in integration tests, use assertThrows for 404
- Wire useChangeSummary hook into GenericProvider context
- Render AI-generated badge on entity descriptions (DescriptionV1)
- Render AI-generated badge on column descriptions (TableDescription)
- Pass changeSummary entry to ColumnDetailPanel's DescriptionSection
- Fix stale useMemo dependency in DescriptionV1 header
- Fix missing Less variable import in description-source-badge.less
- Add Playwright E2E tests for ChangeSummary badge feature
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* Address PR review feedback: fix column FQN parsing, badge labels, backend optimization
- Fix ColumnDetailPanel to use EntityLink.getTableColumnNameFromColumnFqn
instead of naive substring for changeSummary key lookup
- Show correct badge label per source type (AI/Automated/Propagated)
instead of always showing "Automated"
- Fetch only changeDescription field instead of * in both endpoints
- Add @Min/@max validation for limit and offset parameters
- Pass uriInfo to repository calls instead of null
- Pass explicit limit=1000 in GenericProvider to avoid truncated results
- Import ChangeSource from generated/type/changeSummaryMap (correct schema)
- Add getChangeSummaryByFqn to REST client matching API surface
- Add keyboard accessibility (tabIndex, role) to badge
- Remove untranslated "accepted-by" from non-English locales (fallback to en-us)
- Add "ai" label key to en-us locale
- Strengthen integration test assertions to verify non-empty results
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* Improve change summary description layout
* Expand change summary support across assets
* Fix changeSummary race condition and LLMModel entity type mismatch
- Add request cancellation to useChangeSummary hook to prevent stale data
when users switch entities rapidly
- Fix LLMModelResourceIT entity type from "llmmodel" to "llmModel" to match
the registered entity type in Entity.java
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Fix Playwright strict mode violation and sync i18n translations
- Use .first() for ai-suggested-badge locator in ChangeSummaryBadge test
to handle DescriptionV1 rendering the badge in both header and metadata
- Reorder imports per organize-imports rules
- Sync ai-suggested and authored-by keys to all 18 locale files
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix
* fix
* fix
* implemented the new UI changes for AI description
* fixed the lint issues
* addressed gitar comment
* fixed the translations
* fixed unit test
* addressed PR comment
* fixed odcs playwright test
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Pere Miquel Brull <peremiquelbrull@gmail.com>
Co-authored-by: Rohit0301 <rj03012002@gmail.com>
Co-authored-by: Rohit Jain <60229265+Rohit0301@users.noreply.github.com>
SaaiAravindhRaja
pushed a commit
to SaaiAravindhRaja/OpenMetadata
that referenced
this pull request
Apr 12, 2026
* Add changeSummary API endpoint and UI components for description source tracking
Add a new /v1/changeSummary/{entityType}/{id|name/fqn} endpoint that
returns per-field change metadata (who changed it, source type, timestamp).
Supports fieldPrefix filtering for column-level queries on large tables
and limit/offset pagination.
UI additions:
- DescriptionSourceBadge component showing AI badge on AI-generated descriptions
- useChangeSummary hook for fetching change summary data
- changeSummaryAPI REST client
- "accepted-by" translation key
Integration tests added to BaseEntityIT covering all entity types:
get by ID, get by FQN, fieldPrefix filtering, pagination, and 404 cases.
Closes open-metadata#1648
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Fix checkstyle
* Integrate DescriptionSourceBadge into UI and address PR review comments
- Add authorization checks (VIEW_BASIC) to ChangeSummaryResource endpoints
- Fix pagination defaults and simplify pagination logic
- Remove silent try-catch in integration tests, use assertThrows for 404
- Wire useChangeSummary hook into GenericProvider context
- Render AI-generated badge on entity descriptions (DescriptionV1)
- Render AI-generated badge on column descriptions (TableDescription)
- Pass changeSummary entry to ColumnDetailPanel's DescriptionSection
- Fix stale useMemo dependency in DescriptionV1 header
- Fix missing Less variable import in description-source-badge.less
- Add Playwright E2E tests for ChangeSummary badge feature
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* Address PR review feedback: fix column FQN parsing, badge labels, backend optimization
- Fix ColumnDetailPanel to use EntityLink.getTableColumnNameFromColumnFqn
instead of naive substring for changeSummary key lookup
- Show correct badge label per source type (AI/Automated/Propagated)
instead of always showing "Automated"
- Fetch only changeDescription field instead of * in both endpoints
- Add @Min/@max validation for limit and offset parameters
- Pass uriInfo to repository calls instead of null
- Pass explicit limit=1000 in GenericProvider to avoid truncated results
- Import ChangeSource from generated/type/changeSummaryMap (correct schema)
- Add getChangeSummaryByFqn to REST client matching API surface
- Add keyboard accessibility (tabIndex, role) to badge
- Remove untranslated "accepted-by" from non-English locales (fallback to en-us)
- Add "ai" label key to en-us locale
- Strengthen integration test assertions to verify non-empty results
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* Improve change summary description layout
* Expand change summary support across assets
* Fix changeSummary race condition and LLMModel entity type mismatch
- Add request cancellation to useChangeSummary hook to prevent stale data
when users switch entities rapidly
- Fix LLMModelResourceIT entity type from "llmmodel" to "llmModel" to match
the registered entity type in Entity.java
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Fix Playwright strict mode violation and sync i18n translations
- Use .first() for ai-suggested-badge locator in ChangeSummaryBadge test
to handle DescriptionV1 rendering the badge in both header and metadata
- Reorder imports per organize-imports rules
- Sync ai-suggested and authored-by keys to all 18 locale files
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix
* fix
* fix
* implemented the new UI changes for AI description
* fixed the lint issues
* addressed gitar comment
* fixed the translations
* fixed unit test
* addressed PR comment
* fixed odcs playwright test
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Pere Miquel Brull <peremiquelbrull@gmail.com>
Co-authored-by: Rohit0301 <rj03012002@gmail.com>
Co-authored-by: Rohit Jain <60229265+Rohit0301@users.noreply.github.com>
SaaiAravindhRaja
pushed a commit
to SaaiAravindhRaja/OpenMetadata
that referenced
this pull request
Apr 12, 2026
* Add changeSummary API endpoint and UI components for description source tracking
Add a new /v1/changeSummary/{entityType}/{id|name/fqn} endpoint that
returns per-field change metadata (who changed it, source type, timestamp).
Supports fieldPrefix filtering for column-level queries on large tables
and limit/offset pagination.
UI additions:
- DescriptionSourceBadge component showing AI badge on AI-generated descriptions
- useChangeSummary hook for fetching change summary data
- changeSummaryAPI REST client
- "accepted-by" translation key
Integration tests added to BaseEntityIT covering all entity types:
get by ID, get by FQN, fieldPrefix filtering, pagination, and 404 cases.
Closes open-metadata#1648
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Fix checkstyle
* Integrate DescriptionSourceBadge into UI and address PR review comments
- Add authorization checks (VIEW_BASIC) to ChangeSummaryResource endpoints
- Fix pagination defaults and simplify pagination logic
- Remove silent try-catch in integration tests, use assertThrows for 404
- Wire useChangeSummary hook into GenericProvider context
- Render AI-generated badge on entity descriptions (DescriptionV1)
- Render AI-generated badge on column descriptions (TableDescription)
- Pass changeSummary entry to ColumnDetailPanel's DescriptionSection
- Fix stale useMemo dependency in DescriptionV1 header
- Fix missing Less variable import in description-source-badge.less
- Add Playwright E2E tests for ChangeSummary badge feature
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* Address PR review feedback: fix column FQN parsing, badge labels, backend optimization
- Fix ColumnDetailPanel to use EntityLink.getTableColumnNameFromColumnFqn
instead of naive substring for changeSummary key lookup
- Show correct badge label per source type (AI/Automated/Propagated)
instead of always showing "Automated"
- Fetch only changeDescription field instead of * in both endpoints
- Add @Min/@max validation for limit and offset parameters
- Pass uriInfo to repository calls instead of null
- Pass explicit limit=1000 in GenericProvider to avoid truncated results
- Import ChangeSource from generated/type/changeSummaryMap (correct schema)
- Add getChangeSummaryByFqn to REST client matching API surface
- Add keyboard accessibility (tabIndex, role) to badge
- Remove untranslated "accepted-by" from non-English locales (fallback to en-us)
- Add "ai" label key to en-us locale
- Strengthen integration test assertions to verify non-empty results
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* Improve change summary description layout
* Expand change summary support across assets
* Fix changeSummary race condition and LLMModel entity type mismatch
- Add request cancellation to useChangeSummary hook to prevent stale data
when users switch entities rapidly
- Fix LLMModelResourceIT entity type from "llmmodel" to "llmModel" to match
the registered entity type in Entity.java
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Fix Playwright strict mode violation and sync i18n translations
- Use .first() for ai-suggested-badge locator in ChangeSummaryBadge test
to handle DescriptionV1 rendering the badge in both header and metadata
- Reorder imports per organize-imports rules
- Sync ai-suggested and authored-by keys to all 18 locale files
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix
* fix
* fix
* implemented the new UI changes for AI description
* fixed the lint issues
* addressed gitar comment
* fixed the translations
* fixed unit test
* addressed PR comment
* fixed odcs playwright test
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Pere Miquel Brull <peremiquelbrull@gmail.com>
Co-authored-by: Rohit0301 <rj03012002@gmail.com>
Co-authored-by: Rohit Jain <60229265+Rohit0301@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes :
This PR fixes #1617.
Based on #1349, we can now use a proper PUT instead of a POST for creating and updating services.
All ometa integration tests pass with the change. Thanks!
Type of change :
Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.
Checklist:
Reviewers
@harshach @ayush-shah