Skip to content

feat(ui): Announcements in domains and data products#24089

Merged
karanh37 merged 5 commits intomainfrom
domain-dp-announcement
Oct 30, 2025
Merged

feat(ui): Announcements in domains and data products#24089
karanh37 merged 5 commits intomainfrom
domain-dp-announcement

Conversation

@karanh37
Copy link
Contributor

@karanh37 karanh37 commented Oct 30, 2025

Fixes #22123

This pull request adds announcement management functionality for both Domain and Data Product entities, including UI integration and new end-to-end tests. The changes allow users to create, edit, reply to, and delete announcements directly from the entity details pages, with active announcements now displayed and managed via dedicated UI components.

Announcement Management Features:

  • Added announcement creation, editing, replying, and deletion tests for Domains and Data Products in Playwright E2E (Domains.spec.ts), ensuring these workflows are covered by automation.
  • Updated utility functions in entity.ts to support optional alert hiding and announcement actions for improved test flexibility. [1] [2] [3] [4] [5]

UI Integration and Display:

  • Integrated announcement cards and drawers into both DataProductsDetailsPage and DomainDetails components, displaying the active announcement and enabling management actions from the UI. [1] [2] [3] [4]
  • Added announcement management to the "Manage" button dropdowns, gated by permissions, allowing users to open the announcement drawer.

API and State Management:

  • Implemented logic to fetch active announcements for domains and data products using the new getActiveAnnouncement API, updating state and handling errors gracefully. [1] [2] [3]

Imports and Utility Updates:

  • Updated imports to include new announcement-related components, icons, API functions, and utility helpers for feed links and entity names. [1] [2] [3] [4] [5] [6] [7]

These changes collectively enhance the platform's support for announcements, making it easier for users to communicate updates or important information related to domains and data products.

Screenshots

Screenshot 2025-10-30 at 5 04 54 PM Screenshot 2025-10-30 at 5 05 03 PM

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.09% (46787/74158) 39.91% (22034/55215) 43.55% (7028/16139)

@sonarqubecloud
Copy link

@karanh37 karanh37 merged commit 2de0800 into main Oct 30, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FR: Data product level announcements

2 participants