Conversation
Bhanuagr
added
safe to test
There was a problem hiding this comment.
Pull request overview
This PR fixes search percentile rank scoring by increasing the boost factors from very low values (0.05 for weekly stats, 0.1 for monthly stats) to 1.0, which should give percentile rank appropriate weight in search relevance calculations. The change includes:
- Updated default search settings configuration
- New reusable utility for merging search settings during migrations
- v1.11.4 migration that selectively updates only the old default values while preserving user customizations
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| searchSettings.json | Updates default percentileRank factors from 0.05/0.1 to 1.0 for new installations |
| SearchSettingsMergeUtil.java | New reusable utility providing selective merge capabilities for search settings migrations |
| v1114/MigrationUtil.java | Migration logic to update existing installations, preserving user customizations |
| mysql/v1114/Migration.java | MySQL-specific migration entry point invoking the shared migration util |
| postgres/v1114/Migration.java | PostgreSQL-specific migration entry point invoking the shared migration util |
| SearchSettingsMergeUtilTest.java | Comprehensive test suite covering merge scenarios and edge cases |
| mysql/schemaChanges.sql | Placeholder SQL file indicating Java-based migration |
| postgres/schemaChanges.sql | Placeholder SQL file indicating Java-based migration |
The implementation is well-designed with excellent separation of concerns, comprehensive testing, and safe migration logic that respects user customizations. The code follows Java best practices and is consistent with existing migration patterns in the codebase.
Jest test CoverageUI tests summary
|
|
|
|
Failed to cherry-pick changes to the 1.11.4 branch. |
* Fix search percentile rank scoring * Added support for generic methods to merge search settings properties * Added tests for search settings merge util * Fixed palywright test for Restore default search settings
* Fix search percentile rank scoring * Added support for generic methods to merge search settings properties * Added tests for search settings merge util * Fixed palywright test for Restore default search settings
Issue:
Slack Thread
Changes:
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>