Skip to content

test(ui): fix ingestion bot playwright#24946

Merged
karanh37 merged 1 commit intomainfrom
domains-pw
Dec 22, 2025
Merged

test(ui): fix ingestion bot playwright#24946
karanh37 merged 1 commit intomainfrom
domains-pw

Conversation

@karanh37
Copy link
Copy Markdown
Contributor

@karanh37 karanh37 commented Dec 22, 2025

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Test reliability fix:
    • Replaced DOM loader waiting with network response waiting in playwright/utils/domain.ts to eliminate race conditions
  • Removed helper function:
    • Deleted waitForAssetModalInitialLoad in favor of Playwright's page.waitForResponse() pattern
  • Updated test utilities:
    • Applied fix to addAssetsToDomain, addServicesToDomain, and addAssetsToDataProduct functions

This will update automatically on new commits.


@github-actions
Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.3% (50893/79150) 41.89% (24754/59097) 45.38% (7807/17204)

@sonarqubecloud
Copy link
Copy Markdown

@karanh37 karanh37 merged commit ae6cce1 into main Dec 22, 2025
27 of 36 checks passed
@karanh37 karanh37 deleted the domains-pw branch December 22, 2025 09:35
@github-actions
Copy link
Copy Markdown
Contributor

Failed to cherry-pick changes to the 1.11.4 branch.
Please cherry-pick the changes manually.
You can find more details here.

karanh37 added a commit that referenced this pull request Dec 22, 2025
(cherry picked from commit ae6cce1)
ShaileshParmar11 pushed a commit that referenced this pull request Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants