Faster tests

.github/workflows/integration-tests-mysql-elasticsearch.yml

@@ -0,0 +1,119 @@
+#  Copyright 2021 Collate
+#  Licensed under the Apache License, Version 2.0 (the "License");
+#  you may not use this file except in compliance with the License.
+#  You may obtain a copy of the License at
+#  http://www.apache.org/licenses/LICENSE-2.0
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+
+name: Integration Tests - MySQL + Elasticsearch
+
+on:
+  workflow_dispatch:
+  push:
+    branches:
+      - main
+    paths:
+      - "openmetadata-service/**"
+      - "openmetadata-integration-tests/**"
+      - "openmetadata-spec/src/main/resources/json/schema/**"
+      - "openmetadata-sdk/**"
+      - "common/**"
+      - "pom.xml"
+      - "bootstrap/**"
+  pull_request_target:
+    types: [labeled, opened, synchronize, reopened, ready_for_review]
+    paths:
+      - "openmetadata-service/**"
+      - "openmetadata-integration-tests/**"
+      - "openmetadata-spec/src/main/resources/json/schema/**"
+      - "openmetadata-sdk/**"
+      - "common/**"
+      - "pom.xml"
+      - "bootstrap/**"
+
+permissions:
+  contents: read
+  checks: write
+
+concurrency:
+  group: integration-tests-mysql-es-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+jobs:
+  integration-tests-mysql-elasticsearch:
+    runs-on: ubuntu-latest
+    if: ${{ !github.event.pull_request.draft }}
+    steps:
+      - name: Wait for the labeler
+        uses: lewagon/wait-on-check-action@v1.3.4
+        if: ${{ github.event_name == 'pull_request_target' }}
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+          check-name: Team Label
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          wait-interval: 90
+
+      - name: Verify PR labels
+        uses: jesusvasquez333/verify-pr-label-action@v1.4.0
+        if: ${{ github.event_name == 'pull_request_target' }}
+        with:
+          github-token: '${{ secrets.GITHUB_TOKEN }}'
+          valid-labels: 'safe to test'
+          pull-request-number: '${{ github.event.pull_request.number }}'
+          disable-reviews: true  # To not auto approve changes
+
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+
+      - name: Cache Maven dependencies
+        id: cache-output
+        uses: actions/cache@v4
+        with:
+          path: ~/.m2
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-maven-
+
+      - name: Set up JDK 21
+        if: steps.cache-output.outputs.exit-code == 0
+        uses: actions/setup-java@v4
+        with:
+          java-version: '21'
+          distribution: 'temurin'
+
+      - name: Install Ubuntu dependencies
+        if: steps.cache-output.outputs.exit-code == 0
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y unixodbc-dev python3-venv librdkafka-dev gcc libsasl2-dev build-essential libssl-dev libffi-dev \
+          librdkafka-dev unixodbc-dev libevent-dev jq
+          sudo make install_antlr_cli
+
+      - name: Build with Maven
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: mvn -DskipTests clean install -pl '!openmetadata-ui,!openmetadata-docs,!openmetadata-docs-v1' -am
+
+      - name: Run Integration Tests (MySQL + Elasticsearch)
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: mvn test -pl :openmetadata-integration-tests -Pmysql-elasticsearch
+
+      - name: Clean Up
+        run: |
+          cd ./docker/development
+          docker compose down --remove-orphans
+          sudo rm -rf ${PWD}/docker-volume
+
+      - name: Publish Test Report
+        if: ${{ always() }}
+        uses: scacap/action-surefire-report@v1
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          fail_on_test_failures: true
+          report_paths: 'openmetadata-integration-tests/target/surefire-reports/TEST-*.xml'

.github/workflows/integration-tests-postgres-opensearch.yml

@@ -0,0 +1,119 @@
+#  Copyright 2021 Collate
+#  Licensed under the Apache License, Version 2.0 (the "License");
+#  you may not use this file except in compliance with the License.
+#  You may obtain a copy of the License at
+#  http://www.apache.org/licenses/LICENSE-2.0
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+
+name: Integration Tests - PostgreSQL + OpenSearch
+
+on:
+  workflow_dispatch:
+  push:
+    branches:
+      - main
+    paths:
+      - "openmetadata-service/**"
+      - "openmetadata-integration-tests/**"
+      - "openmetadata-spec/src/main/resources/json/schema/**"
+      - "openmetadata-sdk/**"
+      - "common/**"
+      - "pom.xml"
+      - "bootstrap/**"
+  pull_request_target:
+    types: [labeled, opened, synchronize, reopened, ready_for_review]
+    paths:
+      - "openmetadata-service/**"
+      - "openmetadata-integration-tests/**"
+      - "openmetadata-spec/src/main/resources/json/schema/**"
+      - "openmetadata-sdk/**"
+      - "common/**"
+      - "pom.xml"
+      - "bootstrap/**"
+
+permissions:
+  contents: read
+  checks: write
+
+concurrency:
+  group: integration-tests-pg-os-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+jobs:
+  integration-tests-postgres-opensearch:
+    runs-on: ubuntu-latest
+    if: ${{ !github.event.pull_request.draft }}
+    steps:
+      - name: Wait for the labeler
+        uses: lewagon/wait-on-check-action@v1.3.4
+        if: ${{ github.event_name == 'pull_request_target' }}
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+          check-name: Team Label
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          wait-interval: 90
+
+      - name: Verify PR labels
+        uses: jesusvasquez333/verify-pr-label-action@v1.4.0
+        if: ${{ github.event_name == 'pull_request_target' }}
+        with:
+          github-token: '${{ secrets.GITHUB_TOKEN }}'
+          valid-labels: 'safe to test'
+          pull-request-number: '${{ github.event.pull_request.number }}'
+          disable-reviews: true  # To not auto approve changes
+
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+
+      - name: Cache Maven dependencies
+        id: cache-output
+        uses: actions/cache@v4
+        with:
+          path: ~/.m2
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-maven-
+
+      - name: Set up JDK 21
+        if: steps.cache-output.outputs.exit-code == 0
+        uses: actions/setup-java@v4
+        with:
+          java-version: '21'
+          distribution: 'temurin'
+
+      - name: Install Ubuntu dependencies
+        if: steps.cache-output.outputs.exit-code == 0
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y unixodbc-dev python3-venv librdkafka-dev gcc libsasl2-dev build-essential libssl-dev libffi-dev \
+          librdkafka-dev unixodbc-dev libevent-dev jq
+          sudo make install_antlr_cli
+
+      - name: Build with Maven
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: mvn -DskipTests clean install -pl '!openmetadata-ui,!openmetadata-docs,!openmetadata-docs-v1' -am
+
+      - name: Run Integration Tests (PostgreSQL + OpenSearch)
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: mvn test -pl :openmetadata-integration-tests -Ppostgres-opensearch
+
+      - name: Clean Up
+        run: |
+          cd ./docker/development
+          docker compose down --remove-orphans
+          sudo rm -rf ${PWD}/docker-volume
+
+      - name: Publish Test Report
+        if: ${{ always() }}
+        uses: scacap/action-surefire-report@v1
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          fail_on_test_failures: true
+          report_paths: 'openmetadata-integration-tests/target/surefire-reports/TEST-*.xml'

.github/workflows/playwright-sso-tests.yml

@@ -28,7 +28,8 @@
 
 name: SSO Authentication Tests (Nightly)
 
-# schedule:
+on:
+  # schedule:
   #   # Run every night at 2 AM UTC
   #   - cron: '0 2 * * *'
   workflow_dispatch: # Allow manual trigger

CLAUDE.md

@@ -177,12 +177,18 @@ yarn parse-schema              # Parse JSON schemas for frontend (connection and
 
 ### Comments Policy
 - **Do NOT add unnecessary comments** - write self-documenting code
+- **NEVER add single-line comments that describe what the code obviously does**
 - Only include comments for:
     - Complex business logic that isn't obvious
     - Non-obvious algorithms or workarounds
     - Public API JavaDoc documentation
     - TODO/FIXME with ticket references
-- Avoid obvious comments like `// increment counter` or `// create new user`
+- Bad examples (NEVER do this):
+    - `// Create user` before `createUser()`
+    - `// Get client` before `SdkClients.adminClient()`
+    - `// Verify domain is set` before `assertNotNull(entity.getDomain())`
+    - `// User names are lowercased` when the code `toLowerCase()` makes it obvious
+- If the code needs a comment to be understood, refactor the code to be clearer instead
 
 ### Java Code Requirements
 - **Always mention** running `mvn spotless:apply` when generating/modifying .java files