You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request introduces a minor update to the PlatformLineage.spec.ts Playwright test. The main change is the addition of a condition to mark the test as "slow" when not running in open-source (OSS) mode. This helps ensure the test runner allocates more time for completion in certain environments.
Testing improvements:
Marked the Verify Platform Lineage View test as slow if the environment is not OSS, using test.slow(process.env.PLAYWRIGHT_IS_OSS === false).
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Bug fix
Improvement
New feature
Breaking change (fix or feature that would cause existing functionality to not work as expected)
The condition process.env.PLAYWRIGHT_IS_OSS === false will never be true because environment variables are always strings (or undefined), not booleans. Comparing a string to false with strict equality will always return false, making test.slow() never activate.
Impact: The test timeout extension intended for non-OSS environments will never take effect, potentially causing flaky test failures in those environments.
The test.slow() call is missing a semicolon at the end. While JavaScript/TypeScript ASI (Automatic Semicolon Insertion) will handle this, it's inconsistent with typical coding style and may trigger linter warnings.
Fix the type comparison: process.env.PLAYWRIGHT_IS_OSS is a string (or undefined), not a boolean. Comparing it to false with === will always evaluate to false, so test.slow() will never activate.
Add the missing semicolon for consistency with the codebase style.
Options
Auto-apply is off Gitar will not commit updates to this branch. ✅ Code review is on Gitar will review this change. Display: compact Hiding non-applicable rules.
Comment with these commands to change:
Auto-apply
✅ Code review
Compact
gitar auto-apply:on
gitar code-review:off
gitar display:verbose
Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safe to testAdd this label to run secure Github workflows on PRsUIUI specific issues
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a minor update to the
PlatformLineage.spec.tsPlaywright test. The main change is the addition of a condition to mark the test as "slow" when not running in open-source (OSS) mode. This helps ensure the test runner allocates more time for completion in certain environments.Verify Platform Lineage Viewtest as slow if the environment is not OSS, usingtest.slow(process.env.PLAYWRIGHT_IS_OSS === false).Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
test.slow()for Platform Lineage E2E test in non-OSS environmentsThis will update automatically on new commits.