Address PR review comments: fix useMemo dependencies and remove deprecated properties#24981
Conversation
…ix test mocks Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com>
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
ab59b98
into
fix-filters-impact-analysis
🔍 CI failure analysis for 6a7e019: The java-checkstyle CI job failed due to missing 'safe to test' label, not actual code quality issues.IssueThe Root CauseThe failure occurred in a label validation step that checks for the presence of required PR labels. The CI workflow requires the DetailsThis is a configuration/workflow issue, not a code quality problem:
Note: The PR was merged despite this failure, which suggests the label requirement may be optional for certain types of PRs or was overridden by maintainers. Tip Comment OptionsAuto-apply is off Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs) |
* fix(ui): impact analysis filter and sorting * support sorting and highlight to column level * fix dropdown issue * add debounce to search value * add coverage * fix tests * fix tests * update tests * fix sonar comment * Address PR review comments: fix useMemo dependencies and remove deprecated properties (#24981) * Initial plan * Address review comments: fix useMemo deps, remove deprecated props, fix test mocks Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com> * fix pagination logic --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
* fix(ui): impact analysis filter and sorting * support sorting and highlight to column level * fix dropdown issue * add debounce to search value * add coverage * fix tests * fix tests * update tests * fix sonar comment * Address PR review comments: fix useMemo dependencies and remove deprecated properties (#24981) * Initial plan * Address review comments: fix useMemo deps, remove deprecated props, fix test mocks Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com> * fix pagination logic --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
* fix(ui): impact analysis filter and sorting * support sorting and highlight to column level * fix dropdown issue * add debounce to search value * add coverage * fix tests * fix tests * update tests * fix sonar comment * Address PR review comments: fix useMemo dependencies and remove deprecated properties (#24981) * Initial plan * Address review comments: fix useMemo deps, remove deprecated props, fix test mocks Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com> * fix pagination logic --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
* fix(ui): impact analysis filter and sorting * support sorting and highlight to column level * fix dropdown issue * add debounce to search value * add coverage * fix tests * fix tests * update tests * fix sonar comment * Address PR review comments: fix useMemo dependencies and remove deprecated properties (#24981) * Initial plan * Address review comments: fix useMemo deps, remove deprecated props, fix test mocks Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com> * fix pagination logic --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Describe your changes:
Addresses review feedback from PR #24877 by fixing React hooks dependencies, removing deprecated interface properties, and updating test mocks to match the refactored data structure.
React hooks optimization:
currentPageandpageSizeto useMemo dependency array preventing stale data display during pagination (LineageTable.tsx:757-758)columnNameRenderandsearchValueto columnImpactColumns useMemo for explicit dependency tracking (LineageTable.tsx:699)Interface cleanup:
column?: ColumnLineageproperty fromColumnLevelLineageNodeinterface - replaced by flatfromColumn/toColumnstructure (Lineage.interface.ts:74)hideCountsprop fromExploreQuickFiltersProps- already accessed via individual field configurations (ExploreQuickFilters.interface.ts:32)Test updates:
columns: { fromColumns: ['col1'], toColumn: ['col2'] }to flatfromColumn: 'col1', toColumn: 'col2'(LineageTable.test.tsx:358-359)Type of change:
Checklist:
Fixes <issue-number>: <short explanation>💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.