Skip to content

Address PR review comments: fix useMemo dependencies and remove deprecated properties#24981

Merged
chirag-madlani merged 2 commits intofix-filters-impact-analysisfrom
copilot/sub-pr-24877
Dec 23, 2025
Merged

Address PR review comments: fix useMemo dependencies and remove deprecated properties#24981
chirag-madlani merged 2 commits intofix-filters-impact-analysisfrom
copilot/sub-pr-24877

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 23, 2025

Describe your changes:

Addresses review feedback from PR #24877 by fixing React hooks dependencies, removing deprecated interface properties, and updating test mocks to match the refactored data structure.

React hooks optimization:

  • Added missing currentPage and pageSize to useMemo dependency array preventing stale data display during pagination (LineageTable.tsx:757-758)
  • Added columnNameRender and searchValue to columnImpactColumns useMemo for explicit dependency tracking (LineageTable.tsx:699)

Interface cleanup:

  • Removed deprecated column?: ColumnLineage property from ColumnLevelLineageNode interface - replaced by flat fromColumn/toColumn structure (Lineage.interface.ts:74)
  • Removed unused hideCounts prop from ExploreQuickFiltersProps - already accessed via individual field configurations (ExploreQuickFilters.interface.ts:32)

Test updates:

  • Fixed mock data structure in LineageTable.test.tsx from nested columns: { fromColumns: ['col1'], toColumn: ['col2'] } to flat fromColumn: 'col1', toColumn: 'col2' (LineageTable.test.tsx:358-359)

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…ix test mocks

Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix filters impact analysis Address PR review comments: fix useMemo dependencies and remove deprecated properties Dec 23, 2025
Copilot AI requested a review from chirag-madlani December 23, 2025 15:50
@github-actions
Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@chirag-madlani chirag-madlani marked this pull request as ready for review December 23, 2025 17:16
@chirag-madlani chirag-madlani requested a review from a team as a code owner December 23, 2025 17:16
@chirag-madlani chirag-madlani merged commit ab59b98 into fix-filters-impact-analysis Dec 23, 2025
10 of 19 checks passed
@chirag-madlani chirag-madlani deleted the copilot/sub-pr-24877 branch December 23, 2025 17:16
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Dec 23, 2025

🔍 CI failure analysis for 6a7e019: The java-checkstyle CI job failed due to missing 'safe to test' label, not actual code quality issues.

Issue

The java-checkstyle CI job failed with exit code 1 before running any actual checkstyle validation.

Root Cause

The failure occurred in a label validation step that checks for the presence of required PR labels. The CI workflow requires the safe to test label to be present on pull requests before executing checkstyle analysis.

Error! This pull request does not contain any of the valid labels: ['safe to test']
Exiting with an error code

Details

This is a configuration/workflow issue, not a code quality problem:

  • The PR currently has no labels applied
  • The CI workflow has a gate that requires safe to test label for security purposes
  • This prevents the actual java-checkstyle validation from running
  • No Java code was changed in this PR (only TypeScript/test files), so checkstyle wouldn't have flagged anything anyway

Note: The PR was merged despite this failure, which suggests the label requirement may be optional for certain types of PRs or was overridden by maintainers.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off Gitar will not commit updates to this branch.
✅ Code review is on Gitar will review this change.
Display: compact Hiding non-applicable rules.

Comment with these commands to change:

Auto-apply ✅ Code review Compact
gitar auto-apply:on         
gitar code-review:off         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs)

chirag-madlani added a commit that referenced this pull request Dec 24, 2025
* fix(ui): impact analysis filter and sorting

* support sorting and highlight to column level

* fix dropdown issue

* add debounce to search value

* add coverage

* fix tests

* fix tests

* update tests

* fix sonar comment

* Address PR review comments: fix useMemo dependencies and remove deprecated properties (#24981)

* Initial plan

* Address review comments: fix useMemo deps, remove deprecated props, fix test mocks

Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com>

* fix pagination logic

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
ShaileshParmar11 pushed a commit that referenced this pull request Dec 26, 2025
* fix(ui): impact analysis filter and sorting

* support sorting and highlight to column level

* fix dropdown issue

* add debounce to search value

* add coverage

* fix tests

* fix tests

* update tests

* fix sonar comment

* Address PR review comments: fix useMemo dependencies and remove deprecated properties (#24981)

* Initial plan

* Address review comments: fix useMemo deps, remove deprecated props, fix test mocks

Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com>

* fix pagination logic

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
chirag-madlani added a commit that referenced this pull request Feb 10, 2026
* fix(ui): impact analysis filter and sorting

* support sorting and highlight to column level

* fix dropdown issue

* add debounce to search value

* add coverage

* fix tests

* fix tests

* update tests

* fix sonar comment

* Address PR review comments: fix useMemo dependencies and remove deprecated properties (#24981)

* Initial plan

* Address review comments: fix useMemo deps, remove deprecated props, fix test mocks

Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com>

* fix pagination logic

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
chirag-madlani added a commit that referenced this pull request Feb 10, 2026
* fix(ui): impact analysis filter and sorting

* support sorting and highlight to column level

* fix dropdown issue

* add debounce to search value

* add coverage

* fix tests

* fix tests

* update tests

* fix sonar comment

* Address PR review comments: fix useMemo dependencies and remove deprecated properties (#24981)

* Initial plan

* Address review comments: fix useMemo deps, remove deprecated props, fix test mocks

Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com>

* fix pagination logic

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants