-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix: mark iceberg tables in snowflake table metadata ingestion #25566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
🔍 CI failure analysis for 2eeedbb: All CI failures are due to missing 'safe to test' label, not code issues. This is a repository security measure for external PRs.IssueAll CI jobs are failing with the same root cause: missing Root CauseThe OpenMetadata project requires external/community PRs to have a DetailsAll failing jobs show identical error messages: Affected jobs in this run:
The jobs exit immediately during the label validation step without running actual tests. Code Review ✅ ApprovedClean, well-structured change that adds Iceberg table detection following the existing pattern for transient and dynamic tables. No issues found. Tip Comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Describe your changes:
Fixes an issue where Iceberg tables in Snowflake are not properly marked as such.
Updates the
SNOWFLAKE_GET_TABLE_NAMESandSNOWFLAKE_INCREMENTAL_GET_TABLE_NAMESto check theIS_ICEBERGcolumn in the tables view, in order to type any iceberg tables as such when ingested.Type of change:
Checklist: