Skip to content

Conversation

@zak-nuccio
Copy link

Describe your changes:

Fixes an issue where Iceberg tables in Snowflake are not properly marked as such.

Updates the SNOWFLAKE_GET_TABLE_NAMES and SNOWFLAKE_INCREMENTAL_GET_TABLE_NAMES to check the IS_ICEBERG column in the tables view, in order to type any iceberg tables as such when ingested.

Type of change:

  • Improvement

Checklist:

  • I have added tests around the new logic.
  • For connector/ingestion changes: I updated the documentation.

@github-actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@gitar-bot
Copy link

gitar-bot bot commented Feb 5, 2026

🔍 CI failure analysis for 2eeedbb: All CI failures are due to missing 'safe to test' label, not code issues. This is a repository security measure for external PRs.

Issue

All CI jobs are failing with the same root cause: missing safe to test label on this PR.

Root Cause

The OpenMetadata project requires external/community PRs to have a safe to test label before CI jobs will execute. This is a security measure to prevent execution of potentially malicious code from untrusted contributors.

Details

All failing jobs show identical error messages:

Error! This pull request does not contain any of the valid labels: ['safe to test']
Exiting with an error code

Affected jobs in this run:

  • py-run-tests (3.10) - job 62623147358
  • py-checkstyle - job 62623147401
  • build-and-scan - job 62623147484
  • playwright-ci-postgresql (1, 6) - job 62623147574
  • playwright-ci-postgresql (2, 6) - job 62623147685
  • Plus additional shards and test variations

The jobs exit immediately during the label validation step without running actual tests.

Code Review ✅ Approved

Clean, well-structured change that adds Iceberg table detection following the existing pattern for transient and dynamic tables. No issues found.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant