fix: use ConnectionAwareSqlBatch for ChangeEventDAO.insertBatch#25928
Merged
fix: use ConnectionAwareSqlBatch for ChangeEventDAO.insertBatch#25928
Conversation
029e16f to
d9f5fc4
Compare
Code Review ✅ ApprovedClean, well-scoped fix that correctly replaces OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
harshach
approved these changes
Feb 18, 2026
manerow
added a commit
that referenced
this pull request
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



ChangeEventDAO.insertBatchwas using a plain@SqlBatch, which works correctly with MySQL but fails on PostgreSQL. The failure occurs because thechange_event.jsoncolumn is of typejsonbin PostgreSQL and requires an explicit cast fromcharacter varying. As a result, CSV bulk imports (e.g., glossary terms, database schemas, tables, teams, etc.) triggered aBatchUpdateExceptionwhen pending change events were flushed in PostgreSQL deployments.The single-row
insert()method already handled this correctly using@ConnectionAwareSqlUpdatewith a(:json :: jsonb)cast for PostgreSQL. However, the batch variant introduced in #25542 did not include the database-specific handling.I replaced
@SqlBatchwith@ConnectionAwareSqlBatchininsertBatchand added the explicit::jsonbcast for PostgreSQL, aligning it with the existinginsert()implementation and other batch methods in the codebase.I validated the change by running CSV bulk imports against a PostgreSQL setup and confirming that change events are now inserted without triggering
BatchUpdateException.Type of change: