Added fixme for the audit log tests#26020
Conversation
| }); | ||
|
|
||
| test('should search audit logs', async ({ page }) => { | ||
| test.fixme('should search audit logs', async ({ page }) => { |
There was a problem hiding this comment.
💡 Quality: Missing reason/tracking issue for fixme-marked tests
Four tests across two describe blocks are marked as fixme but there's no inline comment or linked issue explaining why they're failing. Playwright's fixme() accepts an optional description string (e.g., test.fixme('reason') or as a second argument) and the PR description uses a placeholder Fixes <issue-number>.
Without context, future developers won't know:
- What failure these tests exhibit
- Whether there's a tracking issue for re-enabling them
- If the root cause is in the test code or the application
This risks the fixme markers becoming permanent technical debt.
Suggested fix:
test.fixme('should search audit logs', async ({ page }) => {
// TODO: Skipped due to <issue-link> - search API returns inconsistent results
Was this helpful? React with 👍 / 👎
| await redirectToHomePage(page); | ||
| await settingClick(page, GlobalSettingOptions.AUDIT_LOGS); | ||
| // Audit log search api has very high latency due to which the test is getting timeout | ||
| test.fixme( |
There was a problem hiding this comment.
💡 Quality: Redundant test.fixme() inside test.describe.fixme() block
The test 'should include filters and search in export request' at line 816 is individually wrapped with test.fixme(), but it's already inside the test.describe.fixme() block (line 690). When a describe block is marked as fixme, all tests within it are automatically skipped. The inner test.fixme() wrapper (and the associated comment and indentation changes) are unnecessary.
This won't cause any functional issue, but removing the redundant wrapper would simplify the code and avoid the indentation churn (lines 815-882).
Suggested fix:
test(
'should include filters and search in export request',
async ({ page }) => {
Was this helpful? React with 👍 / 👎
Code Review 👍 Approved with suggestions 0 resolved / 2 findingsTest-only change correctly disables flaky tests, but still lacks a tracking issue for re-enablement, and one test.fixme() is redundant inside an already-fixme'd describe block. 💡 Quality: Redundant test.fixme() inside test.describe.fixme() block📄 openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/AuditLogs.spec.ts:816 The test This won't cause any functional issue, but removing the redundant wrapper would simplify the code and avoid the indentation churn (lines 815-882). Suggested fix💡 Quality: Missing reason/tracking issue for fixme-marked tests📄 openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/AuditLogs.spec.ts:401 📄 openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/AuditLogs.spec.ts:687 📄 openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/AuditLogs.spec.ts:812 Four tests across two describe blocks are marked as Without context, future developers won't know:
This risks the fixme markers becoming permanent technical debt. Suggested fixOptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
* Added fixme for the audit log tests * added comment
|



Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>