Skip to content

test: Add tags page verification from explore page#26104

Merged
anuj-kumary merged 3 commits intomainfrom
tag-explore
Feb 26, 2026
Merged

test: Add tags page verification from explore page#26104
anuj-kumary merged 3 commits intomainfrom
tag-explore

Conversation

@anuj-kumary
Copy link
Copy Markdown
Member

@anuj-kumary anuj-kumary commented Feb 25, 2026

Describe your changes:

Screenshot 2026-02-25 at 11 19 01 PM

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • New E2E test: Added comprehensive test case verifying Tags page navigation via Explore page's Governance tree and breadcrumb, validating correct page rendering with side panel, table, and column headers (Enabled/Tag/Display Name/Description/Actions)

This will update automatically on new commits.

@anuj-kumary anuj-kumary self-assigned this Feb 25, 2026
@anuj-kumary anuj-kumary requested a review from a team as a code owner February 25, 2026 17:49
@anuj-kumary anuj-kumary added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch labels Feb 25, 2026
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Feb 25, 2026

Code Review ✅ Approved 1 resolved / 1 findings

Clean E2E test addition for Tags page navigation. The previous finding about the fragile SVG locator has been resolved — the code now uses the proper .ant-tree-treenode / .ant-tree-switcher pattern consistent with the rest of the file. No new issues found.

✅ 1 resolved
Edge Case: Fragile SVG locator for expanding Governance tree node

📄 openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/ExploreTree.spec.ts:180
The Governance node expansion uses page.locator('div').filter({ hasText: /^Governance$/ }).locator('svg').first().click() which is fragile — it depends on the exact DOM structure and could match unintended elements if the page layout changes. While this matches the existing pattern at line 105-110, both instances would benefit from a more robust selector.

Consider using a dedicated data-testid on the expand/collapse toggle, or clicking the tree node's expand icon via a more targeted selector like:

await page.getByTestId('explore-tree-title-Governance').locator('..').locator('svg').first().click();

This is a minor concern since it follows the existing codebase convention and the existing test at line 105 uses the same pattern successfully.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions
Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.74% (56548/86012) 45.24% (29634/65506) 47.96% (8924/18607)

@sonarqubecloud
Copy link
Copy Markdown

@anuj-kumary anuj-kumary merged commit ea623e2 into main Feb 26, 2026
31 of 35 checks passed
@anuj-kumary anuj-kumary deleted the tag-explore branch February 26, 2026 04:54
@github-actions
Copy link
Copy Markdown
Contributor

Changes have been cherry-picked to the 1.12.2 branch.

github-actions Bot pushed a commit that referenced this pull request Feb 26, 2026
* test: Add tags page verification from explore page

* nit

* fix minor nit

(cherry picked from commit ea623e2)
aniketkatkar97 added a commit that referenced this pull request Feb 26, 2026
* test: Add tags page verification from explore page

* nit

* fix minor nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants