Delete Old Integration tests and fix sonar workflow

[harshach]

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

• Bug fix
• Improvement
• New feature
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation

Checklist:

• I have read the CONTRIBUTING document.
• My PR title is Fixes <issue-number>: <short explanation>
• I have commented on my code, particularly in hard-to-understand areas.
• For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

---

Summary by Gitar

• Removed legacy integration tests:
  • Deleted 185 test files (~150K lines) including EntityResourceTest, DataContractResourceTest, TableResourceTest, and others covering resources, search, security, workflows, and data quality
  • Removed testcontainers dependencies (PostgreSQL, MySQL, Elasticsearch, OpenSearch, MinIO, K3s, Redis modules)
  • Deleted Maven test profiles (postgres-tests, mysql-tests, postgres-redis-tests, postgres-rdf-tests, mysql-redis-tests) used for containerized integration testing
• Fixed CI workflow:
  • Changed maven-sonar-build.yml: Maven goal from package to verify for proper static-code-analysis profile execution
• Cleaned up test infrastructure:
  • Removed Sonar test configuration properties, testcontainers reuse config, test YAML files, and related test dependencies
  • Retained core testing capability (JUnit 5, Mockito, AssertJ) for unit tests

_{This will update automatically on new commits.}

[gitar-bot]

💡 Quality: Sonar test report paths removed—coverage reporting may degrade

The PR removes sonar.junit.reportPaths, sonar.coverage.jacoco.xmlReportPaths, and sonar.tests properties from openmetadata-service/pom.xml. While these aren't needed for the current -DskipTests workflow, if any other CI job or local workflow runs tests and pushes results to SonarCloud for this module, the test report and coverage data won't be picked up because these paths are no longer configured.

If the intent is that test coverage is now exclusively tracked via the openmetadata-integration-tests module, this is fine. But if SonarCloud is expected to report unit test coverage for openmetadata-service in the future (e.g., for remaining unit tests like RuleEvaluatorTest, CloudWatchEventMonitorTest, etc.), these properties should be re-added or configured at the parent POM level.

_{Was this helpful? React with 👍 / 👎 | Reply gitar fix to apply this suggestion}

[gitar-bot]

💡 Quality: Hardcoded JUnit version instead of using parent property

The newly added junit-jupiter-params dependency hardcodes version 5.9.3 instead of using the ${org.junit.jupiter.version} property defined in the parent POM. While the values currently match, this creates a maintenance risk: if the parent property is updated in the future, this dependency will be left behind, potentially causing version conflicts between JUnit modules (e.g., junit-jupiter-engine at a newer version vs junit-jupiter-params at 5.9.3).

Suggested fix:

<dependency>
  <groupId>org.junit.jupiter</groupId>
  <artifactId>junit-jupiter-params</artifactId>
  <version>${org.junit.jupiter.version}</version>
  <scope>test</scope>
</dependency>

_{Was this helpful? React with 👍 / 👎 | Reply gitar fix to apply this suggestion}

[gitar-bot]

Code Review 👍 Approved with suggestions 0 resolved / 2 findings

Deletes obsolete integration tests and updates the Sonar workflow configuration. Consider using the parent POM property for the JUnit version instead of hardcoding it, and verify that removing Sonar test report paths won't degrade coverage reporting.

💡 Quality: Sonar test report paths removed—coverage reporting may degrade

📄 openmetadata-service/pom.xml:13

The PR removes sonar.junit.reportPaths, sonar.coverage.jacoco.xmlReportPaths, and sonar.tests properties from openmetadata-service/pom.xml. While these aren't needed for the current -DskipTests workflow, if any other CI job or local workflow runs tests and pushes results to SonarCloud for this module, the test report and coverage data won't be picked up because these paths are no longer configured.

If the intent is that test coverage is now exclusively tracked via the openmetadata-integration-tests module, this is fine. But if SonarCloud is expected to report unit test coverage for openmetadata-service in the future (e.g., for remaining unit tests like RuleEvaluatorTest, CloudWatchEventMonitorTest, etc.), these properties should be re-added or configured at the parent POM level.

💡 Quality: Hardcoded JUnit version instead of using parent property

📄 openmetadata-service/pom.xml:573

The newly added junit-jupiter-params dependency hardcodes version 5.9.3 instead of using the ${org.junit.jupiter.version} property defined in the parent POM. While the values currently match, this creates a maintenance risk: if the parent property is updated in the future, this dependency will be left behind, potentially causing version conflicts between JUnit modules (e.g., junit-jupiter-engine at a newer version vs junit-jupiter-params at 5.9.3).

Suggested fix

    <dependency>
      <groupId>org.junit.jupiter</groupId>
      <artifactId>junit-jupiter-params</artifactId>
      <version>${org.junit.jupiter.version}</version>
      <scope>test</scope>
    </dependency>

🤖 Prompt for agents

Code Review: Deletes obsolete integration tests and updates the Sonar workflow configuration. Consider using the parent POM property for the JUnit version instead of hardcoding it, and verify that removing Sonar test report paths won't degrade coverage reporting.

1. 💡 Quality: Sonar test report paths removed—coverage reporting may degrade
   Files: openmetadata-service/pom.xml:13

   The PR removes `sonar.junit.reportPaths`, `sonar.coverage.jacoco.xmlReportPaths`, and `sonar.tests` properties from `openmetadata-service/pom.xml`. While these aren't needed for the current `-DskipTests` workflow, if any other CI job or local workflow runs tests and pushes results to SonarCloud for this module, the test report and coverage data won't be picked up because these paths are no longer configured.
   
   If the intent is that test coverage is now exclusively tracked via the `openmetadata-integration-tests` module, this is fine. But if SonarCloud is expected to report unit test coverage for `openmetadata-service` in the future (e.g., for remaining unit tests like `RuleEvaluatorTest`, `CloudWatchEventMonitorTest`, etc.), these properties should be re-added or configured at the parent POM level.

2. 💡 Quality: Hardcoded JUnit version instead of using parent property
   Files: openmetadata-service/pom.xml:573

   The newly added `junit-jupiter-params` dependency hardcodes version `5.9.3` instead of using the `${org.junit.jupiter.version}` property defined in the parent POM. While the values currently match, this creates a maintenance risk: if the parent property is updated in the future, this dependency will be left behind, potentially causing version conflicts between JUnit modules (e.g., `junit-jupiter-engine` at a newer version vs `junit-jupiter-params` at 5.9.3).

   Suggested fix:
   <dependency>
     <groupId>org.junit.jupiter</groupId>
     <artifactId>junit-jupiter-params</artifactId>
     <version>${org.junit.jupiter.version}</version>
     <scope>test</scope>
   </dependency>

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[sonarqubecloud]

Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud