Skip to content

fix: UI vulnerabilities#26216

Merged
chirag-madlani merged 3 commits intomainfrom
fix-omd-ui-vulnerability
Mar 5, 2026
Merged

fix: UI vulnerabilities#26216
chirag-madlani merged 3 commits intomainfrom
fix-omd-ui-vulnerability

Conversation

@harsh-vador
Copy link
Copy Markdown
Contributor

@harsh-vador harsh-vador commented Mar 4, 2026

Describe your changes:

Fixes:

Summary

Patches transitive npm dependency security vulnerabilities in both openmetadata-ui and openmetadata-ui-core-components by adding/updating resolutions in their respective package.json files.

Vulnerabilities Fixed

# Package Affected Versions Patched Version Impacted Lock File
311 rollup >= 4.0.0, < 4.59.0 4.59.0 openmetadata-ui + openmetadata-ui-core-components
310 minimatch >= 9.0.0, < 9.0.7 9.0.7 openmetadata-ui + openmetadata-ui-core-components
309 minimatch >= 10.0.0, < 10.2.3 10.2.3 openmetadata-ui + openmetadata-ui-core-components
minimatch < 3.1.4 3.1.4 openmetadata-ui

CVE Details

  • Rollup Arbitrary File Write (Path Traversal) — Insecure output filename sanitization allows traversal sequences (../) to overwrite arbitrary files on the host, enabling persistent RCE. Introduced transitively via vite.
  • minimatch ReDoSmatchOne() combinatorial backtracking via multiple non-adjacent GLOBSTAR segments causes denial of service. Affects 3.x, 9.x, and 10.x ranges introduced via eslint, jest, @storybook/react-vite, and vite-plugin-dts.

Changes

  • openmetadata-ui/src/main/resources/ui/package.json

    • minimatch: 3.1.33.1.4
    • Added rollup: 4.59.0
    • Added @storybook/react-vite/minimatch: 9.0.7
    • Added vite-plugin-dts/minimatch: 10.2.3
  • openmetadata-ui-core-components/src/main/resources/ui/package.json

    • Added new resolutions block with rollup: 4.59.0, @storybook/react-vite/minimatch: 9.0.7, vite-plugin-dts/minimatch: 10.2.3

Test plan

  • yarn install in both UI packages regenerates lock files with patched versions
  • yarn build passes in both packages
  • Security scanner reports no remaining CVEs for rollup and minimatch

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harsh-vador harsh-vador self-assigned this Mar 4, 2026
@harsh-vador harsh-vador added the UI UI specific issues label Mar 4, 2026
@harsh-vador harsh-vador requested review from a team and karanh37 as code owners March 4, 2026 09:11
@harsh-vador harsh-vador added the safe to test Add this label to run secure Github workflows on PRs label Mar 4, 2026
siddhant1
siddhant1 previously approved these changes Mar 4, 2026
@harsh-vador harsh-vador added safe to test Add this label to run secure Github workflows on PRs and removed safe to test Add this label to run secure Github workflows on PRs labels Mar 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.93% (57229/86801) 45.52% (30194/66320) 48.38% (9072/18751)

chirag-madlani
chirag-madlani previously approved these changes Mar 4, 2026
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Mar 5, 2026

🔍 CI failure analysis for 9e80b05: The `playwright-ci-postgresql (6, 6)` failure is unrelated to this PR — it consists of one pre-existing hard failure and four flaky tests, none caused by the `rollup`/`minimatch` version pins in `package.json`/`yarn.lock`.

Issue

The playwright-ci-postgresql (6, 6) job failed with 1 hard failure and 4 flaky tests. None of these failures are related to this PR, which only modifies package.json and yarn.lock files to pin rollup and minimatch versions.

Root Cause

Hard Failure: playwright/e2e/Pages/Lineage.spec.ts:466:5expect(locator).toBeVisible() times out (5s) because the lineage node for a table with a / in its name (data-testid containing pw-table-with/slash-...) never renders in the DOM. This is a pre-existing application bug in how special-character entity names are handled in lineage views.

Flaky Tests (4 intermittent failures):

  • playwright/e2e/Pages/Tag.spec.ts:571expect(locator).not.toBeVisible() fails: pw-mlmodel entity remains visible when it should not be (access control state race condition)
  • playwright/e2e/Pages/UserDetails.spec.ts:492 — 60s timeout; browser context closed mid-test (locator.click: Target page, context or browser has been closed)
  • playwright/e2e/Pages/Users.spec.ts:570 — 180s timeout; browser context closed mid-test (locator.waitFor: Target page, context or browser has been closed)
  • playwright/e2e/VersionPages/EntityVersionPages.spec.ts:152TypeError: Cannot read properties of undefined (reading '0') in SearchIndexClass.ts:169entityResponseData.fields is undefined/null in the test fixture

Details

  • This PR only modifies package.json/yarn.lock — no application logic, UI components, or test code was changed
  • The Lineage.spec.ts:466 hard failure and similar flaky tests were also observed in the previous CI run on this PR, confirming these are pre-existing issues not introduced by these changes
  • 596 tests passed; only these 5 tests exhibited issues
  • The browser context closure failures (UserDetails, Users) indicate resource/infrastructure flakiness during the long-running (~58 min) test suite, unrelated to dependency version changes
Code Review ✅ Approved

UI vulnerability fixes applied with no issues found. Changes are safe to test and ready to merge.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 5, 2026

@chirag-madlani chirag-madlani disabled auto-merge March 5, 2026 09:08
@chirag-madlani chirag-madlani merged commit bf526c7 into main Mar 5, 2026
22 of 23 checks passed
@chirag-madlani chirag-madlani deleted the fix-omd-ui-vulnerability branch March 5, 2026 09:08
harsh-vador added a commit that referenced this pull request Mar 16, 2026
(cherry picked from commit bf526c7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants