Skip to content

Fixed Profiler configuration playwright test#26223

Merged
ShaileshParmar11 merged 1 commit intomainfrom
fix-profiler-config-test
Mar 4, 2026
Merged

Fixed Profiler configuration playwright test#26223
ShaileshParmar11 merged 1 commit intomainfrom
fix-profiler-config-test

Conversation

@ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Mar 4, 2026

Describe your changes:

Fixed Profiler configuration playwright test

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Updated profiler metrics:
    • Added nullMissingCount and valueRank to metrics list in Playwright test constant
    • Added MetricType enum with all metric types to 5 generated interface files
  • Enhanced pipeline configuration:
    • Added optional metrics?: MetricType[] property to profiler pipeline interfaces for selective metric computation
  • Improved documentation:
    • Clarified useStatistics field descriptions to specify "table metrics" instead of just "metrics"

This will update automatically on new commits.

@gitar-bot
Copy link

gitar-bot bot commented Mar 4, 2026

Code Review ✅ Approved

The code looks good and is approved.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.93% (57230/86801) 45.53% (30198/66320) 48.39% (9073/18751)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2026

@ShaileshParmar11 ShaileshParmar11 enabled auto-merge (squash) March 4, 2026 14:26
@ShaileshParmar11 ShaileshParmar11 merged commit a3cf8bd into main Mar 4, 2026
33 of 35 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the fix-profiler-config-test branch March 4, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants