Skip to content

Fixed the Auto Classification E2E#26279

Merged
aniketkatkar97 merged 1 commit intomainfrom
fix-auto-classification-e2e
Mar 6, 2026
Merged

Fixed the Auto Classification E2E#26279
aniketkatkar97 merged 1 commit intomainfrom
fix-auto-classification-e2e

Conversation

@Rohit0301
Copy link
Contributor

@Rohit0301 Rohit0301 commented Mar 6, 2026

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Test fixes:
    • Updated bot name from testsuite-bot to autoClassification-bot in auto classification test
    • Reformatted import statement for improved readability
  • Type refactoring:
    • Extracted Service interface from TableClass for better type organization
    • Updated constructor to accept Partial<Service> and use service name when provided

This will update automatically on new commits.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
66% (57263/86750) 45.63% (30192/66154) 48.41% (9066/18725)

@gitar-bot
Copy link

gitar-bot bot commented Mar 6, 2026

🔍 CI failure analysis for ce69a90: The `playwright-ci-postgresql (6, 6)` job completed with 7 test failures out of 609 tests — 6 of which are marked flaky — none in files modified by this PR.

Issue

The playwright-ci-postgresql (6, 6) job ran 609 tests with 7 failures (6 flaky, 1 hard failure). None of the failing tests are in files modified by this PR (AutoClassification.spec.ts, TableClass.ts).

Root Cause

The failures appear to be pre-existing instability and flakiness unrelated to this PR's changes:

  • Lineage.spec.ts:466 — Timeout (60s): lineage node element never became visible
  • ExplorePageRightPanel.spec.ts:1971 — Strict mode violation: [data-testid="loader"] resolved to 2 elements (flaky)
  • Glossary.spec.ts:2133 and :2342 — Test data ID mismatch between runs (flaky)
  • Tag.spec.ts:571 — Entity name visibility check timed out (flaky)
  • Users.spec.ts:570 — Timeout (180s): browser context closed prematurely (flaky)
  • EntityVersionPages.spec.ts:152TypeError: Cannot read properties of undefined (reading '0')this.entityResponseData.fields[0] accessed when fields is empty/undefined in SearchIndexClass.ts:169

Details

All failing tests are in unrelated spec files. 6 of 7 failures are classified as flaky. The EntityVersionPages failure involves a null-safety issue in SearchIndexClass.ts (not modified by this PR).

Previous CI runs also failed with a safe to test label gate — that issue is now resolved since the label has been applied.

Code Review ✅ Approved

Fixed the Auto Classification E2E test with no issues found.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2026

@aniketkatkar97
Copy link
Member

Known failure Lineage.spec.ts. Fix is already in progress.

@aniketkatkar97 aniketkatkar97 merged commit e599299 into main Mar 6, 2026
23 of 24 checks passed
@aniketkatkar97 aniketkatkar97 deleted the fix-auto-classification-e2e branch March 6, 2026 11:58
Rohit0301 added a commit that referenced this pull request Mar 9, 2026
@Rohit0301 Rohit0301 restored the fix-auto-classification-e2e branch March 17, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants