Skip to content

chore(ui): add card component#26290

Merged
karanh37 merged 2 commits intomainfrom
untitled-ui-card
Mar 6, 2026
Merged

chore(ui): add card component#26290
karanh37 merged 2 commits intomainfrom
untitled-ui-card

Conversation

@karanh37
Copy link
Contributor

@karanh37 karanh37 commented Mar 6, 2026


Summary by Gitar

  • New Card component:
    • Added reusable Card component in card.tsx with focus ring, rounded corners, and ring styling
    • Exported Card from main components index for public API access
  • Storybook stories:
    • Added four Card story variants: Default, WithImage, WithFooter, and CustomWidth demonstrating usage patterns

This will update automatically on new commits.

@gitar-bot
Copy link

gitar-bot bot commented Mar 6, 2026

Code Review ✅ Approved 1 resolved / 1 findings

Adds a new card UI component with proper overflow handling to ensure images respect rounded corners. No remaining issues found.

✅ 1 resolved
Bug: Card missing overflow-hidden — images bleed past rounded corners

📄 openmetadata-ui-core-components/src/main/resources/ui/src/components/base/card/card.tsx:25 📄 openmetadata-ui-core-components/src/main/resources/ui/src/stories/Card.stories.tsx:48
The Card component applies tw:rounded-xl but does not include tw:overflow-hidden. When child content fills the card edge-to-edge (e.g., the gradient in the WithImage story), it will visually bleed past the rounded corners because the overflow is not clipped.

The story description on line 48 even states the image "overflows the card edges cleanly due to overflow-hidden," but this class is absent from the component itself.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@karanh37 karanh37 merged commit 8158f18 into main Mar 6, 2026
20 of 21 checks passed
@karanh37 karanh37 deleted the untitled-ui-card branch March 6, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants