Skip to content

fix(ui): Background color for summary panel in add test case drawer#26683

Merged
shah-harshit merged 3 commits intomainfrom
issue-26682
Mar 23, 2026
Merged

fix(ui): Background color for summary panel in add test case drawer#26683
shah-harshit merged 3 commits intomainfrom
issue-26682

Conversation

@shah-harshit
Copy link
Contributor

@shah-harshit shah-harshit commented Mar 23, 2026

Summary

Adjusts the embedded Entity summary panel styling in the Add test case drawer so it aligns cleanly with the service requirements / documentation column.

Issue:
Image

Fix:
Screenshot 2026-03-23 at 12 12 43 PM

Changes

  • Scope: .test-case-form-drawer .drawer-content-wrapper .drawer-doc-panel
  • .entity-summary-in-docs: set vertical margins to 0 so the summary block no longer inherits extra top/bottom margin from the generic service-doc panel rules (which was causing the panel to look visually misaligned against the doc panel background).
  • .entity-summary-panel-container: add top padding (@padding-xs) so content spacing matches the drawer layout.

Testing

  • Open Add test case from Data Quality, confirm the right-hand summary + docs column looks correct with no odd gap or background seam.

Fixes #26682

- Zero vertical margin on .entity-summary-in-docs inside the doc panel
- Top padding on .entity-summary-panel-container for alignment with requirements content

Made-with: Cursor
@shah-harshit shah-harshit requested a review from a team as a code owner March 23, 2026 06:41
@github-actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@shah-harshit shah-harshit self-assigned this Mar 23, 2026
@shah-harshit shah-harshit added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Mar 23, 2026
@shah-harshit shah-harshit changed the title Fix background color for summary panel in add test case drawer fix(ui): Background color for summary panel in add test case drawer Mar 23, 2026
@shah-harshit shah-harshit enabled auto-merge (squash) March 23, 2026 06:45
@gitar-bot
Copy link

gitar-bot bot commented Mar 23, 2026

Code Review ✅ Approved

Fixes the background color for the summary panel in the add test case drawer with adjusted spacing. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
65% (58011/89244) 44.76% (30676/68525) 47.75% (9176/19215)

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2026

🟡 Playwright Results — all passed (15 flaky)

✅ 3394 passed · ❌ 0 failed · 🟡 15 flaky · ⏭️ 183 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 453 0 2 2
✅ Shard 2 305 0 0 1
🟡 Shard 3 669 0 6 33
🟡 Shard 4 686 0 2 41
✅ Shard 5 672 0 0 73
🟡 Shard 6 609 0 5 33
🟡 15 flaky test(s) (passed on retry)
  • Features/CustomizeDetailPage.spec.ts › Search Index - customization should work (shard 1, 1 retry)
  • Pages/AuditLogs.spec.ts › should apply both User and EntityType filters simultaneously (shard 1, 2 retries)
  • Features/BulkImport.spec.ts › Database (shard 3, 1 retry)
  • Features/DataQuality/TestCaseIncidentPermissions.spec.ts › User with TEST_CASE.EDIT_ALL can see edit icon on incidents (shard 3, 1 retry)
  • Features/DataQuality/TestCaseResultPermissions.spec.ts › User with only VIEW cannot PATCH results (shard 3, 1 retry)
  • Features/Glossary/GlossaryWorkflow.spec.ts › should start term as Draft when glossary has reviewers (shard 3, 1 retry)
  • Features/Permissions/GlossaryPermissions.spec.ts › Team-based permissions work correctly (shard 3, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/DataContractInheritance.spec.ts › Delete Asset Contract - Falls back to showing inherited contract from Data Product (shard 4, 1 retry)
  • Pages/Lineage.spec.ts › Lineage creation from Table entity (shard 6, 2 retries)
  • Pages/Lineage.spec.ts › Lineage creation from ApiEndpoint entity (shard 6, 2 retries)
  • Pages/ODCSImportExport.spec.ts › Multi-object ODCS contract - object selector shows all schema objects (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)
  • VersionPages/EntityVersionPages.spec.ts › Directory (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@shah-harshit shah-harshit merged commit cabf27b into main Mar 23, 2026
49 of 50 checks passed
@shah-harshit shah-harshit deleted the issue-26682 branch March 23, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix background color for summary panel in add test case drawer

3 participants