Skip to content

Chore(UI): Playwright test util improvement#26769

Merged
aniketkatkar97 merged 2 commits intomainfrom
oss-requirements
Mar 25, 2026
Merged

Chore(UI): Playwright test util improvement#26769
aniketkatkar97 merged 2 commits intomainfrom
oss-requirements

Conversation

@aniketkatkar97
Copy link
Copy Markdown
Member

@aniketkatkar97 aniketkatkar97 commented Mar 25, 2026

I worked on adding a tab selection logic while searching by text to avoid flakiness


Summary by Gitar

  • Refactored function signatures:
    • Converted navigateToExploreAndSelectEntity and openEntitySummaryPanel from positional to object parameters for improved clarity
    • Updated 40+ call sites in ExplorePageRightPanel.spec.ts to use new object-based syntax
  • Enhanced tab selection:
    • Added exploreTab parameter to enable tab selection logic when searching by text to reduce test flakiness

This will update automatically on new commits.

@aniketkatkar97 aniketkatkar97 self-assigned this Mar 25, 2026
Copilot AI review requested due to automatic review settings March 25, 2026 12:44
@github-actions github-actions Bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Mar 25, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Playwright Explore-page test utilities to reduce flakiness by allowing callers to specify an Explore left-panel tab to select before continuing entity selection.

Changes:

  • Extended navigateToExploreAndSelectEntity to accept an optional exploreTab parameter and pass it through.
  • Extended openEntitySummaryPanel to optionally click a specified Explore left-panel tab after executing a search.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
openmetadata-ui/src/main/resources/ui/playwright/utils/explore.ts Adds an optional exploreTab parameter to the high-level Explore navigation helper.
openmetadata-ui/src/main/resources/ui/playwright/utils/entityPanel.ts Implements Explore left-panel tab selection inside the entity summary panel opening helper.

Comment thread openmetadata-ui/src/main/resources/ui/playwright/utils/explore.ts Outdated
@aniketkatkar97 aniketkatkar97 requested a review from a team as a code owner March 25, 2026 13:03
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Mar 25, 2026

Code Review ✅ Approved

Playwright test utility improvements add tab selection logic during text searches to eliminate flakiness. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions
Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
65.01% (58080/89328) 44.8% (30712/68547) 47.8% (9196/19235)

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

🟡 Playwright Results — all passed (22 flaky)

✅ 3409 passed · ❌ 0 failed · 🟡 22 flaky · ⏭️ 209 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 454 0 1 2
🟡 Shard 2 602 0 3 32
🟡 Shard 3 610 0 5 28
🟡 Shard 4 597 0 6 47
🟡 Shard 5 586 0 1 67
🟡 Shard 6 560 0 6 33
🟡 22 flaky test(s) (passed on retry)
  • Pages/UserCreationWithPersona.spec.ts › Create user with persona and verify on profile (shard 1, 1 retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/BulkImport.spec.ts › Keyboard Delete selection (shard 2, 1 retry)
  • Features/DataProductPersonaCustomization.spec.ts › Data Product - customization should work (shard 2, 1 retry)
  • Features/LandingPageWidgets/FollowingWidget.spec.ts › Check followed entity present in following widget (shard 3, 1 retry)
  • Features/Permissions/GlossaryPermissions.spec.ts › Team-based permissions work correctly (shard 3, 1 retry)
  • Flow/ExploreDiscovery.spec.ts › Should not display soft deleted assets in search suggestions (shard 3, 1 retry)
  • Flow/PersonaDeletionUserProfile.spec.ts › User profile loads correctly before and after persona deletion (shard 3, 1 retry)
  • Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for MlModel (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Data consumer can manage domain as owner (shard 4, 1 retry)
  • Pages/DomainUIInteractions.spec.ts › Rename data product via UI (shard 4, 1 retry)
  • Pages/DomainUIInteractions.spec.ts › Delete data product via UI (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Set & Update table-cp, hyperlink-cp, string, integer, markdown, number, duration, email, enum, sqlQuery, timestamp, entityReference, entityReferenceList, timeInterval, time-cp, date-cp, dateTime-cp Custom Property (shard 4, 1 retry)
  • Pages/EntityDataSteward.spec.ts › Glossary Term Add, Update and Remove (shard 5, 1 retry)
  • Pages/Lineage.spec.ts › Lineage creation from ApiEndpoint entity (shard 6, 1 retry)
  • Pages/ODCSImportExport.spec.ts › Multi-object ODCS contract - object selector shows all schema objects (shard 6, 1 retry)
  • Pages/Teams.spec.ts › Teams Page Flow (shard 6, 1 retry)
  • Pages/UserDetails.spec.ts › Create team with domain and verify visibility of inherited domain in user profile after team removal (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)
  • VersionPages/EntityVersionPages.spec.ts › Directory (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@aniketkatkar97 aniketkatkar97 merged commit 3ef98a6 into main Mar 25, 2026
45 checks passed
@aniketkatkar97 aniketkatkar97 deleted the oss-requirements branch March 25, 2026 16:50
aniketkatkar97 added a commit that referenced this pull request Apr 24, 2026
* Add tab selection logic while searching by text to avoid flakiness

* Worked on comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants