Make OpeNMetadata Service Unit Test Required#27099
Conversation
Code Review ✅ ApprovedMakes the OpenMetadata Service Unit Test required in the CI/CD pipeline. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions workflow for OpenMetadata service unit tests to run the Maven test job across a database matrix (MySQL and PostgreSQL), with per-database test report naming to support branch protection / required-check gating.
Changes:
- Add a matrix strategy to run
openmetadata-serviceunit tests formysqlandpostgresql. - Include the database selector in the Maven profile list and in artifact / test report check naming.
| run: | | ||
| mvn -B clean package -pl openmetadata-service -am \ | ||
| -Pstatic-code-analysis \ | ||
| -Pstatic-code-analysis,${{ matrix.database }} \ | ||
| -DfailIfNoTests=false \ |
There was a problem hiding this comment.
The matrix adds -P... ,${{ matrix.database }} but Maven profiles mysql/postgresql don’t appear to be defined in the root pom.xml or openmetadata-service/pom.xml (they only exist in openmetadata-sdk/pom.xml). With mvn ... -pl openmetadata-service -am, those profiles are likely not available/active, so this will run the same unit test suite twice and won’t actually switch database behavior.
Consider either defining these profiles in the root/service POM (so they apply to this build) or passing an explicit property/env that the service tests actually consume (e.g., -Dtest.database=...) and wiring tests to use it.
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>