Skip to content

fix: Resolve frontend security vulnerabilities in lodash and lodash-es#27105

Merged
harsh-vador merged 4 commits intomainfrom
fix-lodash-vulnerability
Apr 7, 2026
Merged

fix: Resolve frontend security vulnerabilities in lodash and lodash-es#27105
harsh-vador merged 4 commits intomainfrom
fix-lodash-vulnerability

Conversation

@harsh-vador
Copy link
Copy Markdown
Contributor

@harsh-vador harsh-vador commented Apr 6, 2026

Describe your changes:

Summary

Both are patched in lodash ≥ 4.18.0.

Changes

Workspace Before After
openmetadata-ui/src/main/resources/ui lodash 4.18.0, lodash-es 4.18.0 lodash 4.18.1, lodash-es 4.18.1
openmetadata-ui-core-components/src/main/resources/ui lodash 4.17.23 (blocked by vite-plugin-dts → @microsoft/api-extractor) lodash 4.18.1 via resolutions override
Root lodash 4.17.23 (via quicktype@20.0.27) lodash 4.18.1 via resolutions override
  • Added resolutions: { "lodash": "4.18.1" } to root package.json to override the transitive constraint from quicktype
  • Added "lodash": "4.18.1" to the resolutions block in openmetadata-ui-core-components package.json to override the lodash@~4.17.23 constraint from vite-plugin-dts@4.5.4 → @microsoft/api-extractor@7.57.6
  • Bumped lodash and lodash-es direct dependency and resolutions in openmetadata-ui from 4.18.04.18.1

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harsh-vador harsh-vador self-assigned this Apr 6, 2026
@harsh-vador harsh-vador requested a review from a team as a code owner April 6, 2026 16:51
@harsh-vador harsh-vador added safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch labels Apr 6, 2026
Comment thread openmetadata-ui/src/main/resources/ui/package.json Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.28% (59497/92559) 43.77% (31014/70847) 46.94% (9355/19928)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2026

🟡 Playwright Results — all passed (28 flaky)

✅ 3590 passed · ❌ 0 failed · 🟡 28 flaky · ⏭️ 207 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 452 0 5 2
🟡 Shard 2 641 0 1 32
🟡 Shard 3 646 0 5 26
🟡 Shard 4 615 0 7 47
🟡 Shard 5 606 0 1 67
🟡 Shard 6 630 0 9 33
🟡 28 flaky test(s) (passed on retry)
  • Features/DataAssetRulesDisabled.spec.ts › Verify the Topic entity item action after rules disabled (shard 1, 1 retry)
  • Features/DataAssetRulesDisabled.spec.ts › Verify the Container entity item action after rules disabled (shard 1, 1 retry)
  • Features/CustomizeDetailPage.spec.ts › API Endpoint - customization should work (shard 1, 1 retry)
  • Flow/Tour.spec.ts › Tour should work from welcome screen (shard 1, 1 retry)
  • Pages/UserCreationWithPersona.spec.ts › Create user with persona and verify on profile (shard 1, 1 retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/OntologyExplorer.spec.ts › should open relation type dropdown and show All option (shard 3, 1 retry)
  • Features/Permissions/GlossaryPermissions.spec.ts › Team-based permissions work correctly (shard 3, 1 retry)
  • Features/UserProfileOnlineStatus.spec.ts › Should not show online status for inactive users (shard 3, 1 retry)
  • Flow/ExploreDiscovery.spec.ts › Should display deleted assets when showDeleted is checked and deleted is not present in queryFilter (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › Enum (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Rename domain with subdomains attached verifies subdomain accessibility (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Rename domain with owners and experts preserves assignments (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Subdomain rename does not affect parent domain and updates nested children (shard 4, 1 retry)
  • Pages/DomainUIInteractions.spec.ts › Navigate from data product to parent domain (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Tag and Glossary Selector should close vice versa (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Announcement create, edit & delete (shard 4, 1 retry)
  • Pages/ExploreTree.spec.ts › Verify Database and Database Schema available in explore tree (shard 5, 1 retry)
  • Pages/Lineage/DataAssetLineage.spec.ts › verify create lineage for entity - Table (shard 6, 1 retry)
  • Pages/Lineage/DataAssetLineage.spec.ts › verify create lineage for entity - Metric (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/ProfilerConfigurationPage.spec.ts › Non admin user (shard 6, 1 retry)
  • Pages/Teams.spec.ts › Add New Team in Department Team (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)
  • Pages/Users.spec.ts › Check permissions for Data Steward (shard 6, 1 retry)
  • VersionPages/EntityVersionPages.spec.ts › Topic (shard 6, 1 retry)
  • VersionPages/EntityVersionPages.spec.ts › Directory (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@harsh-vador harsh-vador enabled auto-merge (squash) April 7, 2026 04:03
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 7, 2026

Code Review ✅ Approved 1 resolved / 1 findings

Upgrades lodash and lodash-es to 4.18.1 across all workspaces to resolve frontend security vulnerabilities. No issues found.

✅ 1 resolved
Security: lodash-es resolution downgraded from >=4.18.1 to 4.18.0

📄 openmetadata-ui/src/main/resources/ui/package.json:299 📄 openmetadata-ui/src/main/resources/ui/package.json:129 📄 openmetadata-ui/src/main/resources/ui/package.json:298-299
The resolutions entry for lodash-es changed from ">=4.18.1" to "4.18.0". This is a downgrade, not an upgrade — any security fixes present in 4.18.1 (which was the previous minimum) would be lost. If the goal is to fix vulnerabilities, the resolution should be at least 4.18.1 or higher, not 4.18.0.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 7, 2026

@harsh-vador harsh-vador merged commit ca170ff into main Apr 7, 2026
54 of 55 checks passed
@harsh-vador harsh-vador deleted the fix-lodash-vulnerability branch April 7, 2026 07:55
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

Failed to cherry-pick changes to the 1.12.5 branch.
Please cherry-pick the changes manually.
You can find more details here.

SaaiAravindhRaja pushed a commit to SaaiAravindhRaja/OpenMetadata that referenced this pull request Apr 12, 2026
open-metadata#27105)

* fix: Resolve frontend security vulnerabilities in lodash and lodash-es

* fix(security): bump lodash and lodash-es to 4.18.1 across all workspaces
SaaiAravindhRaja pushed a commit to SaaiAravindhRaja/OpenMetadata that referenced this pull request Apr 12, 2026
open-metadata#27105)

* fix: Resolve frontend security vulnerabilities in lodash and lodash-es

* fix(security): bump lodash and lodash-es to 4.18.1 across all workspaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants