fix: action buttons visible immediately despite slow pipelineStatus API by Rohit0301 · Pull Request #27139 · open-metadata/OpenMetadata

Rohit0301 · 2026-04-07T17:39:20Z

Describe your changes:

On the Ingestion List table, the action buttons (Run, Pause, Logs) were not visible until the pipelineStatus API responded. When this API had high latency, users were blocked from interacting with pipelines.

Root cause: Permissions and run history were fetched sequentially — action buttons only rendered after both APIs settled.

Fire permissions and run history fetches concurrently. Each updates state independently as soon as it settles:

Permissions settle → action buttons render immediately
Run history settles → status dots render (independently)

Fixes 27100

I worked on ... because ...

Fixed the recent runs overlapping issue.

Type of change:

Checklist:

I have read the CONTRIBUTING document.
My PR title is Fixes <issue-number>: <short explanation>
I have commented on my code, particularly in hard-to-understand areas.
For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

github-actions · 2026-04-07T18:43:14Z

Jest test Coverage

UI tests summary

Lines	Statements	Branches	Functions
	64.28% (59497/92555)	43.78% (31019/70851)	46.94% (9357/19930)

github-actions · 2026-04-07T20:03:03Z

🔴 Playwright Results — 1 failure(s), 19 flaky

✅ 3621 passed · ❌ 1 failed · 🟡 19 flaky · ⏭️ 209 skipped

Shard	Passed	Failed	Flaky	Skipped
🟡 Shard 1	477	0	3	4
🟡 Shard 2	640	0	2	32
🟡 Shard 3	648	0	3	26
🟡 Shard 4	617	0	5	47
🔴 Shard 5	605	1	1	67
🟡 Shard 6	634	0	5	33

Genuine Failures (failed on all attempts)

❌ Pages/Glossary.spec.ts › Add and Remove Assets (shard 5)

�[31mTest timeout of 180000ms exceeded.�[39m

🟡 19 flaky test(s) (passed on retry)

Flow/SearchRBAC.spec.ts › User without permission (shard 1, 1 retry)
Features/CustomizeDetailPage.spec.ts › API Endpoint - customization should work (shard 1, 1 retry)
Pages/UserCreationWithPersona.spec.ts › Create user with persona and verify on profile (shard 1, 1 retry)
Features/BulkEditEntity.spec.ts › Table (shard 2, 1 retry)
Features/BulkImport.spec.ts › Keyboard Delete selection (shard 2, 1 retry)
Features/Permissions/GlossaryPermissions.spec.ts › Team-based permissions work correctly (shard 3, 1 retry)
Features/UserProfileOnlineStatus.spec.ts › Should not show online status for inactive users (shard 3, 1 retry)
Flow/ExploreDiscovery.spec.ts › Should not display soft deleted assets in search suggestions (shard 3, 1 retry)
Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
Pages/DataContracts.spec.ts › Create Data Contract and validate for Directory (shard 4, 1 retry)
Pages/DomainDataProductsRightPanel.spec.ts › Should display overview tab for data product (shard 4, 1 retry)
Pages/Domains.spec.ts › Data Product announcement create, edit & delete (shard 4, 1 retry)
Pages/Domains.spec.ts › Multiple consecutive domain renames preserve all associations (shard 4, 1 retry)
Pages/ExploreTree.spec.ts › Verify Database and Database Schema available in explore tree (shard 5, 1 retry)
Pages/Lineage/DataAssetLineage.spec.ts › Column lineage for dashboard -> dashboardDataModel (shard 6, 1 retry)
Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
Pages/ProfilerConfigurationPage.spec.ts › Non admin user (shard 6, 1 retry)
Pages/UserDetails.spec.ts › Create team with domain and verify visibility of inherited domain in user profile after team removal (shard 6, 1 retry)
Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)

📦 Download artifacts

How to debug locally

# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

ShaileshParmar11 · 2026-04-08T13:34:18Z

+          slowTestPipeline.fullyQualifiedName
+        )}/pipelineStatus**`,
+        async (route) => {
+          await page.waitForTimeout(8000);


why we are adding manual wait?

@ShaileshParmar11 This timeout is added to increase the latency of that API to test few changes on UI.

ShaileshParmar11 · 2026-04-08T13:37:21Z

+      // Verify the run was triggered by checking the pipeline row shows a running state
+      await expect(
+        pipelineRow.getByTestId('pipeline-status').first()
+      ).toBeVisible({ timeout: 15000 });


in every step i see random timeout, what the reason of it, and do we even need it?

added this timeout is added because we need to check few things on UI after the api response came for the api for which we have increased the latency by mocking it.

gitar-bot · 2026-04-10T17:57:09Z

Code Review ✅ Approved 2 resolved / 2 findings

Fixes action buttons now displaying immediately by silencing permission promise errors and removing unreachable .catch() handlers that relied on Promise.allSettled rejecting.

✅ 2 resolved

✅ Bug: Permission promise errors are silently swallowed

📄 openmetadata-ui/src/main/resources/ui/src/components/Settings/Services/Ingestion/IngestionListTable/IngestionListTable.tsx:204-213
The Promise.allSettled(permissionPromises).then(...) chain at line 204 has no .catch() handler. While Promise.allSettled itself never rejects, the .then() callback can throw (e.g., if ingestionData[index] is unexpectedly undefined and .name access throws). If that happens, the rejection is unhandled — no error toast, no loading state cleanup, and it may trigger an unhandledrejection warning in the browser.

In contrast, the run-history chain at line 215 correctly has .catch() and .finally().

This is also a minor semantic issue: isIngestionRunsLoading is set to true at the top but only cleared when the run-history promise settles. If the permission promise errors, there's no issue with loading state — but if the run-history promise somehow doesn't execute (unlikely but defensive), loading would remain true forever.

✅ Quality: Promise.allSettled never rejects — .catch() handlers are dead code

📄 openmetadata-ui/src/main/resources/ui/src/components/Settings/Services/Ingestion/IngestionListTable/IngestionListTable.tsx:215 📄 openmetadata-ui/src/main/resources/ui/src/components/Settings/Services/Ingestion/IngestionListTable/IngestionListTable.tsx:241
Promise.allSettled() by specification always resolves (never rejects), even when individual promises fail. The .catch() handlers on lines 215 and 241 are unreachable dead code, which gives a false sense of error coverage.

Because the individual results are already handled inside .then() via cv.status === 'fulfilled', no additional error handling is needed at the outer promise level.

Options

Display: compact → Showing less information.

Comment with these commands to change:

`Compact`
`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Gitar}

…PI (open-metadata#27139) * fix: action buttons visible immediately despite slow pipelineStatus API * fixed the recent run overlapping issue * addressed gitar comment * addressed PR comment * addressed gitar comment * fixed lint checks

…PI (#27139) * fix: action buttons visible immediately despite slow pipelineStatus API * fixed the recent run overlapping issue * addressed gitar comment * addressed PR comment * addressed gitar comment * fixed lint checks

sonarqubecloud · 2026-04-17T11:42:50Z

Quality Gate passed for 'open-metadata-ui'

Issues
1085 New issues
0 Accepted issues

Measures
14 Security Hotspots
0.0% Coverage on New Code
3.9% Duplication on New Code

See analysis details on SonarQube Cloud

fix: action buttons visible immediately despite slow pipelineStatus API

a954605

Rohit0301 self-assigned this Apr 7, 2026

Rohit0301 added the safe to test Add this label to run secure Github workflows on PRs label Apr 7, 2026

Rohit0301 requested a review from a team as a code owner April 7, 2026 17:39

gitar-bot bot reviewed Apr 7, 2026

View reviewed changes

Comment thread ...rces/ui/src/components/Settings/Services/Ingestion/IngestionListTable/IngestionListTable.tsx

Rohit0301 had a problem deploying to test April 7, 2026 17:49 — with GitHub Actions Error

fixed the recent run overlapping issue

6830e31

Rohit0301 mentioned this pull request Apr 7, 2026

"Recent Runs" and "Status" columns overlapping in Metadata Agents table #27100

Closed

addressed gitar comment

9b5b89c

Rohit0301 temporarily deployed to test April 7, 2026 18:17 — with GitHub Actions Inactive

Rohit0301 had a problem deploying to test April 7, 2026 18:17 — with GitHub Actions Failure

Rohit0301 temporarily deployed to test April 7, 2026 18:17 — with GitHub Actions Inactive

Rohit0301 temporarily deployed to test April 8, 2026 06:28 — with GitHub Actions Inactive

ShaileshParmar11 requested changes Apr 8, 2026

View reviewed changes

addressed PR comment

36961ce

gitar-bot bot reviewed Apr 10, 2026

View reviewed changes

Comment thread ...rces/ui/src/components/Settings/Services/Ingestion/IngestionListTable/IngestionListTable.tsx Outdated

addressed gitar comment

e0725c0

Rohit0301 had a problem deploying to test April 10, 2026 17:50 — with GitHub Actions Error

fixed lint checks

fac65c7

Rohit0301 temporarily deployed to test April 10, 2026 18:06 — with GitHub Actions Inactive

ShaileshParmar11 approved these changes Apr 11, 2026

View reviewed changes

Rohit0301 merged commit 2ca0109 into main Apr 11, 2026
45 checks passed

Rohit0301 deleted the fix-3480 branch April 11, 2026 18:23

nikhilchennam added the To release Will cherry-pick this PR into the release branch label Apr 17, 2026

nikhilchennam temporarily deployed to test April 17, 2026 11:11 — with GitHub Actions Inactive

nikhilchennam had a problem deploying to test April 17, 2026 11:11 — with GitHub Actions Failure

nikhilchennam temporarily deployed to test April 17, 2026 11:11 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: action buttons visible immediately despite slow pipelineStatus API#27139

fix: action buttons visible immediately despite slow pipelineStatus API#27139
Rohit0301 merged 6 commits intomainfrom
fix-3480

Rohit0301 commented Apr 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Apr 7, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 7, 2026 •

edited

Loading

Uh oh!

ShaileshParmar11 Apr 8, 2026

Uh oh!

Rohit0301 Apr 9, 2026

Uh oh!

ShaileshParmar11 Apr 8, 2026

Uh oh!

Rohit0301 Apr 9, 2026

Uh oh!

Uh oh!

gitar-bot bot commented Apr 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

sonarqubecloud bot commented Apr 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Rohit0301 commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes:

Type of change:

Checklist:

Uh oh!

Uh oh!

github-actions bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jest test Coverage

UI tests summary

Uh oh!

github-actions bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔴 Playwright Results — 1 failure(s), 19 flaky

Genuine Failures (failed on all attempts)

Uh oh!

ShaileshParmar11 Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Rohit0301 Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

ShaileshParmar11 Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Rohit0301 Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gitar-bot bot commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Apr 17, 2026

Quality Gate passed for 'open-metadata-ui'

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Rohit0301 commented Apr 7, 2026 •

edited

Loading

github-actions bot commented Apr 7, 2026 •

edited

Loading

github-actions bot commented Apr 7, 2026 •

edited

Loading

gitar-bot bot commented Apr 10, 2026 •

edited

Loading