fix(ui): add fallback to interaction required error in MsalAuthenticator by chirag-madlani · Pull Request #27189 · open-metadata/OpenMetadata

chirag-madlani · 2026-04-09T04:43:45Z

renewIdToken in MsalAuthenticator would propagate InteractionRequiredAuthError when silent token acquisition failed, instead of attempting an interactive popup fallback. The test suite also asserted this broken behavior.

Changes:

MsalAuthenticator.tsx: renewIdToken now calls fetchIdToken(true), enabling the InteractionRequiredAuthError → loginPopup fallback path instead of throwing immediately.
MsalAuthenticator.test.tsx:
- Replaced the stale test that expected renewIdToken to throw InteractionRequiredAuthError with two new cases:
  - Silent failure → popup succeeds → token returned
  - Silent failure → popup also fails → error propagates
- Added missing mocks for showErrorToast, Transi18next, and getPopupSettingLink (used in the popup error-handling branch)

Type of change:

Checklist:

I have read the CONTRIBUTING document.
My PR title is Fixes <issue-number>: <short explanation>
I have commented on my code, particularly in hard-to-understand areas.
For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.

Copilot

Pull request overview

This PR updates the UI’s MSAL authenticator token renewal path so that when silent token acquisition fails with InteractionRequiredAuthError, renewIdToken will allow an interactive popup fallback instead of immediately failing.

Changes:

Updated renewIdToken to call fetchIdToken(true) to enable popup fallback behavior during token renewal.

...etadata-ui/src/main/resources/ui/src/components/Auth/AppAuthenticators/MsalAuthenticator.tsx

Agent-Logs-Url: https://github.com/open-metadata/OpenMetadata/sessions/b430d4e3-eead-4b95-9b4e-0b6775ca20e6 Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com>

gitar-bot · 2026-04-09T05:03:45Z

Code Review ✅ Approved

Adds fallback handling for interaction required errors in MsalAuthenticator to improve error resilience in the UI authentication flow. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

`Compact`
`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Gitar}

github-actions · 2026-04-09T06:51:45Z

Jest test Coverage

UI tests summary

Lines	Statements	Branches	Functions
	64.27% (59556/92656)	43.76% (31031/70904)	46.94% (9363/19943)

sonarqubecloud · 2026-04-09T06:54:07Z

Quality Gate passed for 'open-metadata-ui'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-04-09T07:14:56Z

Failed to cherry-pick changes to the 1.12.5 branch.
Please cherry-pick the changes manually.
You can find more details here.

…tor (#27189) * fix(ui): add fallback to interaction required error * fix(ui): update MsalAuthenticator test to validate popup-fallback path Agent-Logs-Url: https://github.com/open-metadata/OpenMetadata/sessions/b430d4e3-eead-4b95-9b4e-0b6775ca20e6 Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> (cherry picked from commit af7ffe7)

github-actions · 2026-04-09T08:23:41Z

🟡 Playwright Results — all passed (23 flaky)

✅ 3138 passed · ❌ 0 failed · 🟡 23 flaky · ⏭️ 205 skipped

Shard	Passed	Flaky	Skipped
🟡 Shard 2	637	5	32
🟡 Shard 3	649	2	26
🟡 Shard 4	618	4	47
🟡 Shard 5	604	3	67
🟡 Shard 6	630	9	33

🟡 23 flaky test(s) (passed on retry)

Features/DataProductPersonaCustomization.spec.ts › Data Product - customization should work (shard 2, 1 retry)
Features/DataQuality/BundleSuiteBulkOperations.spec.ts › Add test case to existing Bundle Suite (shard 2, 1 retry)
Features/DataQuality/TestCaseImportExportE2eFlow.spec.ts › Admin: Complete export-import-validate flow (shard 2, 1 retry)
Features/DataQuality/TestCaseIncidentPermissions.spec.ts › User with only VIEW cannot PATCH incidents (shard 2, 1 retry)
Features/DataQuality/TestCaseResultPermissions.spec.ts › User with TEST_CASE.EDIT_ALL can see edit action on test case (shard 2, 1 retry)
Features/Permissions/GlossaryPermissions.spec.ts › Team-based permissions work correctly (shard 3, 1 retry)
Flow/ExploreDiscovery.spec.ts › Should display deleted assets when showDeleted is checked and deleted is not present in queryFilter (shard 3, 1 retry)
Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
Pages/DataContracts.spec.ts › Create Data Contract and validate for DashboardDataModel (shard 4, 1 retry)
Pages/Domains.spec.ts › Rename domain with deeply nested subdomains (3+ levels) verifies FQN propagation (shard 4, 1 retry)
Pages/Domains.spec.ts › Multiple consecutive domain renames preserve all associations (shard 4, 1 retry)
Pages/EntityDataConsumer.spec.ts › Tier Add, Update and Remove (shard 5, 1 retry)
Pages/ExploreTree.spec.ts › Verify Database and Database Schema available in explore tree (shard 5, 1 retry)
Pages/Glossary.spec.ts › Add and Remove Assets (shard 5, 1 retry)
Pages/Glossary.spec.ts › Column dropdown drag-and-drop functionality for Glossary Terms table (shard 6, 1 retry)
Pages/GlossaryImportExport.spec.ts › Glossary Bulk Import Export (shard 6, 1 retry)
Pages/HyperlinkCustomProperty.spec.ts › should display URL when no display text is provided (shard 6, 1 retry)
Pages/Lineage/DataAssetLineage.spec.ts › verify create lineage for entity - Stored Procedure (shard 6, 1 retry)
Pages/Lineage/DataAssetLineage.spec.ts › verify create lineage for entity - Api Endpoint (shard 6, 1 retry)
Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
Pages/ODCSImportExport.spec.ts › Multi-object ODCS contract - object selector shows all schema objects (shard 6, 1 retry)
Pages/ProfilerConfigurationPage.spec.ts › Non admin user (shard 6, 1 retry)
Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)

📦 Download artifacts

How to debug locally

# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

…tor (open-metadata#27189) * fix(ui): add fallback to interaction required error * fix(ui): update MsalAuthenticator test to validate popup-fallback path Agent-Logs-Url: https://github.com/open-metadata/OpenMetadata/sessions/b430d4e3-eead-4b95-9b4e-0b6775ca20e6 Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

fix(ui): add fallback to interaction required error

6192615

Copilot AI review requested due to automatic review settings April 9, 2026 04:43

chirag-madlani added the To release Will cherry-pick this PR into the release branch label Apr 9, 2026

github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Apr 9, 2026

Copilot started reviewing on behalf of chirag-madlani April 9, 2026 04:44 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

...etadata-ui/src/main/resources/ui/src/components/Auth/AppAuthenticators/MsalAuthenticator.tsx Show resolved Hide resolved

chirag-madlani temporarily deployed to test April 9, 2026 04:53 — with GitHub Actions Inactive

chirag-madlani had a problem deploying to test April 9, 2026 04:53 — with GitHub Actions Error

chirag-madlani temporarily deployed to test April 9, 2026 04:53 — with GitHub Actions Inactive

chirag-madlani had a problem deploying to test April 9, 2026 04:53 — with GitHub Actions Error

Copilot started work on behalf of chirag-madlani April 9, 2026 04:58 View session

fix(ui): update MsalAuthenticator test to validate popup-fallback path

44435fa

Agent-Logs-Url: https://github.com/open-metadata/OpenMetadata/sessions/b430d4e3-eead-4b95-9b4e-0b6775ca20e6 Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com>

Copilot AI requested a review from a team as a code owner April 9, 2026 05:01

Copilot AI changed the title ~~fix(ui): add fallback to interaction required error~~ fix(ui): add fallback to interaction required error in MsalAuthenticator Apr 9, 2026

Copilot finished work on behalf of chirag-madlani April 9, 2026 05:02

pmbrull approved these changes Apr 9, 2026

View reviewed changes

Copilot AI temporarily deployed to test April 9, 2026 06:34 Inactive

Copilot AI had a problem deploying to test April 9, 2026 06:34 Failure

pmbrull merged commit af7ffe7 into main Apr 9, 2026
44 of 45 checks passed

pmbrull deleted the fix-safar-msal-auth branch April 9, 2026 07:13

harshach mentioned this pull request Apr 9, 2026

MSAL Token Renewal Fix — Safari Session Loss #27214

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ui): add fallback to interaction required error in MsalAuthenticator#27189

fix(ui): add fallback to interaction required error in MsalAuthenticator#27189
pmbrull merged 2 commits intomainfrom
fix-safar-msal-auth

chirag-madlani commented Apr 9, 2026 •

edited by Copilot AI

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

gitar-bot bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

sonarqubecloud bot commented Apr 9, 2026

Uh oh!

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

chirag-madlani commented Apr 9, 2026 • edited by Copilot AI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes:

Type of change:

Checklist:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

gitar-bot bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 9, 2026

Jest test Coverage

UI tests summary

Uh oh!

sonarqubecloud bot commented Apr 9, 2026

Quality Gate passed for 'open-metadata-ui'

Uh oh!

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

github-actions bot commented Apr 9, 2026

🟡 Playwright Results — all passed (23 flaky)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chirag-madlani commented Apr 9, 2026 •

edited by Copilot AI

Loading

gitar-bot bot commented Apr 9, 2026 •

edited

Loading