Chore(UI): Fix flakiness in AutoPilot and ServiceEntity#27226
Merged
aniketkatkar97 merged 9 commits intomainfrom Apr 15, 2026
Merged
Chore(UI): Fix flakiness in AutoPilot and ServiceEntity#27226aniketkatkar97 merged 9 commits intomainfrom
aniketkatkar97 merged 9 commits intomainfrom
Conversation
aniketkatkar97
added
the
To release
github-actions
Bot
added
safe to test
aniketkatkar97
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Improves Playwright test stability by tightening navigation and toast-notification waits in shared utilities.
Changes:
- Update
redirectToHomePageto navigate withwaitUntil: 'domcontentloaded'before continuing. - Update
toastNotificationto wait for the specific alert-bar content matching the provided message (and forward the optionaltimeout).
Contributor
Jest test CoverageUI tests summary
|
| timeout?: number | ||
| ) => { | ||
| await page.getByTestId('alert-bar').waitFor({ | ||
| await page.getByTestId('alert-bar').getByText(message).waitFor({ |
There was a problem hiding this comment.
toastNotification now uses getByText(message) which does substring matching by default for string messages. This reduces assertion specificity compared to the previous toHaveText check and can allow the helper to pass even when the toast text contains additional/unexpected content. Consider using exact matching for string messages (e.g., getByText(message, { exact: true }) when typeof message === 'string') or otherwise restoring an explicit assertion that the visible toast message matches the expected text.
Suggested change
| await page.getByTestId('alert-bar').getByText(message).waitFor({ | |
| const alertBar = page.getByTestId('alert-bar'); | |
| const toastMessage = | |
| typeof message === 'string' | |
| ? alertBar.getByText(message, { exact: true }) | |
| : alertBar.getByText(message); | |
| await toastMessage.waitFor({ |
Code Review ✅ ApprovedStabilizes UI test execution for AutoPilot and ServiceEntity components by addressing intermittent flakiness. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
Contributor
🟡 Playwright Results — all passed (27 flaky)✅ 3629 passed · ❌ 0 failed · 🟡 27 flaky · ⏭️ 84 skipped
🟡 27 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Rohit0301
approved these changes
Apr 15, 2026
Contributor
|
Changes have been cherry-picked to the 1.12.6 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes targeted improvements to the Playwright utility functions in
common.tsto enhance test reliability and specificity. The main changes focus on improving page navigation and toast notification handling.Navigation improvements:
redirectToHomePageto usewaitUntil: 'domcontentloaded'when navigating to the home page, ensuring the DOM is loaded before proceeding.Toast notification handling:
toastNotificationto wait specifically for the alert bar containing the provided message text, and to pass through the optional timeout parameter for more precise test control. Removed redundant checks for the alert bar text.